tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

s390/ctcm: Use info level for handshake UC_RCRESET

CTC adapter throws CTC_EVENT_UC_RCRESET (Unit check remote reset event)
during initial handshake, if the peer is not ready yet. This causes the
ctcm driver to re-attempt the handshake.

As it is normal for the event to occur during initialization, use info
instead of warn level in kernel log and NOTICE instead of ERROR level
in s390 debug feature. Also reword the log message for clarity.

Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Aswin Karuvally <aswin@linux.ibm.com>
Link: https://patch.msgid.link/20251103101652.2349855-1-aswin@linux.ibm.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Aswin Karuvally and committed by
Paolo Abeni 0cc4b846 f47b0c11

+14
+14
drivers/s390/net/ctcm_fsms.c
··· 882 882 fsm_newstate(fi, CTC_STATE_RXERR); 883 883 fsm_event(priv->fsm, DEV_EVENT_RXDOWN, dev); 884 884 } 885 + } else if (event == CTC_EVENT_UC_RCRESET) { 886 + CTCM_DBF_TEXT_(TRACE, CTC_DBF_NOTICE, 887 + "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id, 888 + ctc_ch_event_names[event], fsm_getstate_str(fi)); 889 + 890 + dev_info(&dev->dev, 891 + "Init handshake not received, peer not ready yet\n"); 885 892 } else { 886 893 CTCM_DBF_TEXT_(ERROR, CTC_DBF_ERROR, 887 894 "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id, ··· 974 967 fsm_newstate(fi, CTC_STATE_TXERR); 975 968 fsm_event(priv->fsm, DEV_EVENT_TXDOWN, dev); 976 969 } 970 + } else if (event == CTC_EVENT_UC_RCRESET) { 971 + CTCM_DBF_TEXT_(TRACE, CTC_DBF_NOTICE, 972 + "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id, 973 + ctc_ch_event_names[event], fsm_getstate_str(fi)); 974 + 975 + dev_info(&dev->dev, 976 + "Init handshake not sent, peer not ready yet\n"); 977 977 } else { 978 978 CTCM_DBF_TEXT_(ERROR, CTC_DBF_ERROR, 979 979 "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id,