tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks

If ext2_get_blocks() is called with maxblocks == 0, it currently triggers
a BUG_ON(), causing a kernel panic.

While this condition implies a logic error in the caller, a filesystem
should not crash the system due to invalid arguments.

Replace the BUG_ON() with a WARN_ON_ONCE() to provide a stack trace for
debugging, and return -EINVAL to handle the error gracefully.

Signed-off-by: Milos Nikic <nikic.milos@gmail.com>
Link: https://patch.msgid.link/20260207010617.216675-1-nikic.milos@gmail.com
Signed-off-by: Jan Kara <jack@suse.cz>

authored by

Milos Nikic and committed by
Jan Kara 0cf9c58b 6d942c87

+2 -1
+2 -1
fs/ext2/inode.c
··· 638 638 int count = 0; 639 639 ext2_fsblk_t first_block = 0; 640 640 641 - BUG_ON(maxblocks == 0); 641 + if (WARN_ON_ONCE(maxblocks == 0)) 642 + return -EINVAL; 642 643 643 644 depth = ext2_block_to_path(inode,iblock,offsets,&blocks_to_boundary); 644 645