tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: target: core: add missing file_{start,end}_write()

The callers of vfs_iter_write() are required to hold file_start_write().
file_start_write() is a no-op for the S_ISBLK() case, but it is really
needed when the backing file is a regular file.

We are going to move file_{start,end}_write() into vfs_iter_write(), but
we need to fix this first, so that the fix could be backported to stable
kernels.

Suggested-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/ZV8ETIpM+wZa33B5@infradead.org/
Cc: <stable@vger.kernel.org>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Link: https://lore.kernel.org/r/20231123092000.2665902-1-amir73il@gmail.com
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>

authored by

Amir Goldstein and committed by
Christian Brauner 0db1d539 b85ea95d

+7 -3
+7 -3
drivers/target/target_core_file.c
··· 332 332 } 333 333 334 334 iov_iter_bvec(&iter, is_write, bvec, sgl_nents, len); 335 - if (is_write) 335 + if (is_write) { 336 + file_start_write(fd); 336 337 ret = vfs_iter_write(fd, &iter, &pos, 0); 337 - else 338 + file_end_write(fd); 339 + } else { 338 340 ret = vfs_iter_read(fd, &iter, &pos, 0); 339 - 341 + } 340 342 if (is_write) { 341 343 if (ret < 0 || ret != data_length) { 342 344 pr_err("%s() write returned %d\n", __func__, ret); ··· 469 467 } 470 468 471 469 iov_iter_bvec(&iter, ITER_SOURCE, bvec, nolb, len); 470 + file_start_write(fd_dev->fd_file); 472 471 ret = vfs_iter_write(fd_dev->fd_file, &iter, &pos, 0); 472 + file_end_write(fd_dev->fd_file); 473 473 474 474 kfree(bvec); 475 475 if (ret < 0 || ret != len) {