Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
iio: adc: exynos: Simplify with dev_err_probe
Use dev_err_probe() to make error code handling simpler and handle
deferred probe nicely (avoid spamming logs).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
authored by
Krzysztof Kozlowski
and committed by
Jonathan Cameron
0dce3f98
dcc3ac29
+10
-19
+10
-19
drivers/iio/adc/exynos_adc.c
+10
-19
drivers/iio/adc/exynos_adc.c
···
564
564
info = iio_priv(indio_dev);
565
565
566
566
info->data = exynos_adc_get_data(pdev);
567
-
if (!info->data) {
568
-
dev_err(&pdev->dev, "failed getting exynos_adc_data\n");
569
-
return -EINVAL;
570
-
}
567
+
if (!info->data)
568
+
return dev_err_probe(&pdev->dev, -EINVAL, "failed getting exynos_adc_data\n");
571
569
572
570
info->regs = devm_platform_ioremap_resource(pdev, 0);
573
571
if (IS_ERR(info->regs))
···
576
578
info->pmu_map = syscon_regmap_lookup_by_phandle(
577
579
pdev->dev.of_node,
578
580
"samsung,syscon-phandle");
579
-
if (IS_ERR(info->pmu_map)) {
580
-
dev_err(&pdev->dev, "syscon regmap lookup failed.\n");
581
-
return PTR_ERR(info->pmu_map);
582
-
}
581
+
if (IS_ERR(info->pmu_map))
582
+
return dev_err_probe(&pdev->dev, PTR_ERR(info->pmu_map),
583
+
"syscon regmap lookup failed.\n");
583
584
}
584
585
585
586
irq = platform_get_irq(pdev, 0);
···
590
593
init_completion(&info->completion);
591
594
592
595
info->clk = devm_clk_get(&pdev->dev, "adc");
593
-
if (IS_ERR(info->clk)) {
594
-
dev_err(&pdev->dev, "failed getting clock, err = %ld\n",
595
-
PTR_ERR(info->clk));
596
-
return PTR_ERR(info->clk);
597
-
}
596
+
if (IS_ERR(info->clk))
597
+
return dev_err_probe(&pdev->dev, PTR_ERR(info->clk), "failed getting clock\n");
598
598
599
599
if (info->data->needs_sclk) {
600
600
info->sclk = devm_clk_get(&pdev->dev, "sclk");
601
-
if (IS_ERR(info->sclk)) {
602
-
dev_err(&pdev->dev,
603
-
"failed getting sclk clock, err = %ld\n",
604
-
PTR_ERR(info->sclk));
605
-
return PTR_ERR(info->sclk);
606
-
}
601
+
if (IS_ERR(info->sclk))
602
+
return dev_err_probe(&pdev->dev, PTR_ERR(info->sclk),
603
+
"failed getting sclk clock\n");
607
604
}
608
605
609
606
info->vdd = devm_regulator_get(&pdev->dev, "vdd");