tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: txgbe: fix to clear interrupt status after handling IRQ

GPIO EOI is not set to clear interrupt status after handling the
interrupt. It should be done in irq_chip->irq_ack, but this function
is not called in handle_nested_irq(). So executing function
txgbe_gpio_irq_ack() manually in txgbe_gpio_irq_handler().

Fixes: aefd013624a1 ("net: txgbe: use irq_domain for interrupt controller")
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Link: https://lore.kernel.org/r/20240301092956.18544-2-jiawenwu@trustnetic.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Jiawen Wu and committed by
Paolo Abeni 0e71862a b4a2496c

+2
+2
drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c
··· 475 475 gc = txgbe->gpio; 476 476 for_each_set_bit(hwirq, &gpioirq, gc->ngpio) { 477 477 int gpio = irq_find_mapping(gc->irq.domain, hwirq); 478 + struct irq_data *d = irq_get_irq_data(gpio); 478 479 u32 irq_type = irq_get_trigger_type(gpio); 479 480 481 + txgbe_gpio_irq_ack(d); 480 482 handle_nested_irq(gpio); 481 483 482 484 if ((irq_type & IRQ_TYPE_SENSE_MASK) == IRQ_TYPE_EDGE_BOTH) {