tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

accel/ivpu: replace use of system_wq with system_percpu_wq

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

system_wq should be the per-cpu workqueue, yet in this name nothing makes
that clear, so replace system_wq with system_percpu_wq.

The old wq (system_wq) will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
Link: https://patch.msgid.link/20251029165642.364488-3-marco.crivellari@suse.com

authored by

Marco Crivellari and committed by
Karol Wachowski 0f5b2982 7b1a70c3

+6 -5
+1 -1
drivers/accel/ivpu/ivpu_hw_btrs.c
··· 673 673 674 674 if (REG_TEST_FLD(VPU_HW_BTRS_LNL_INTERRUPT_STAT, SURV_ERR, status)) { 675 675 ivpu_dbg(vdev, IRQ, "Survivability IRQ\n"); 676 - queue_work(system_wq, &vdev->irq_dct_work); 676 + queue_work(system_percpu_wq, &vdev->irq_dct_work); 677 677 } 678 678 679 679 if (REG_TEST_FLD(VPU_HW_BTRS_LNL_INTERRUPT_STAT, FREQ_CHANGE, status)) {
+1 -1
drivers/accel/ivpu/ivpu_ipc.c
··· 459 459 } 460 460 } 461 461 462 - queue_work(system_wq, &vdev->irq_ipc_work); 462 + queue_work(system_percpu_wq, &vdev->irq_ipc_work); 463 463 } 464 464 465 465 void ivpu_ipc_irq_work_fn(struct work_struct *work)
+1 -1
drivers/accel/ivpu/ivpu_job.c
··· 591 591 * status and ensure both are handled in the same way 592 592 */ 593 593 job->file_priv->has_mmu_faults = true; 594 - queue_work(system_wq, &vdev->context_abort_work); 594 + queue_work(system_percpu_wq, &vdev->context_abort_work); 595 595 return true; 596 596 } 597 597 default:
+1 -1
drivers/accel/ivpu/ivpu_mmu.c
··· 970 970 } 971 971 } 972 972 973 - queue_work(system_wq, &vdev->context_abort_work); 973 + queue_work(system_percpu_wq, &vdev->context_abort_work); 974 974 } 975 975 976 976 void ivpu_mmu_evtq_dump(struct ivpu_device *vdev)
+2 -1
drivers/accel/ivpu/ivpu_pm.c
··· 226 226 unsigned long timeout_ms = ivpu_tdr_timeout_ms ? ivpu_tdr_timeout_ms : vdev->timeout.tdr; 227 227 228 228 /* No-op if already queued */ 229 - queue_delayed_work(system_wq, &vdev->pm->job_timeout_work, msecs_to_jiffies(timeout_ms)); 229 + queue_delayed_work(system_percpu_wq, &vdev->pm->job_timeout_work, 230 + msecs_to_jiffies(timeout_ms)); 230 231 } 231 232 232 233 void ivpu_stop_job_timeout_detection(struct ivpu_device *vdev)