tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

spi: mpc52xx: fix controller deregistration

Make sure to deregister the controller before disabling and releasing
underlying resources like interrupts and gpios during driver unbind.

Fixes: 42bbb70980f3 ("powerpc/5200: Add mpc5200-spi (non-PSC) device driver")
Fixes: b8d4e2ce60b6 ("mpc52xx_spi: add gpio chipselect")
Cc: stable@vger.kernel.org # 2.6.33
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260414134319.978196-4-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Johan Hovold and committed by
Mark Brown 0f997fda 964ee979

+2 -1
+2 -1
drivers/spi/spi-mpc52xx.c
··· 517 517 struct mpc52xx_spi *ms = spi_controller_get_devdata(host); 518 518 int i; 519 519 520 + spi_unregister_controller(host); 521 + 520 522 cancel_work_sync(&ms->work); 521 523 free_irq(ms->irq0, ms); 522 524 free_irq(ms->irq1, ms); ··· 527 525 gpiod_put(ms->gpio_cs[i]); 528 526 529 527 kfree(ms->gpio_cs); 530 - spi_unregister_controller(host); 531 528 iounmap(ms->regs); 532 529 spi_controller_put(host); 533 530 }