tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/balloon_compaction: remove balloon_page_push/pop()

Let's remove these helpers as they are unused now.

Link: https://lkml.kernel.org/r/20260119230133.3551867-14-david@kernel.org
Signed-off-by: David Hildenbrand (Red Hat) <david@kernel.org>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Eugenio Pérez <eperezma@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Jerrin Shaji George <jerrin.shaji-george@broadcom.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: SeongJae Park <sj@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

David Hildenbrand (Red Hat) and committed by
Andrew Morton 0fa3e9a4 f7e15373

+2 -33
-30
include/linux/balloon_compaction.h
··· 126 126 set_page_private(page, 0); 127 127 /* PageOffline is sticky until the page is freed to the buddy. */ 128 128 } 129 - 130 - /* 131 - * balloon_page_push - insert a page into a page list. 132 - * @head : pointer to list 133 - * @page : page to be added 134 - * 135 - * Caller must ensure the page is private and protect the list. 136 - */ 137 - static inline void balloon_page_push(struct list_head *pages, struct page *page) 138 - { 139 - list_add(&page->lru, pages); 140 - } 141 - 142 - /* 143 - * balloon_page_pop - remove a page from a page list. 144 - * @head : pointer to list 145 - * @page : page to be added 146 - * 147 - * Caller must ensure the page is private and protect the list. 148 - */ 149 - static inline struct page *balloon_page_pop(struct list_head *pages) 150 - { 151 - struct page *page = list_first_entry_or_null(pages, struct page, lru); 152 - 153 - if (!page) 154 - return NULL; 155 - 156 - list_del(&page->lru); 157 - return page; 158 - } 159 129 #endif /* _LINUX_BALLOON_COMPACTION_H */
+2 -3
mm/balloon_compaction.c
··· 128 128 * Drivers must call this function to properly enqueue a new allocated balloon 129 129 * page before definitively removing the page from the guest system. 130 130 * 131 - * Drivers must not call balloon_page_enqueue on pages that have been pushed to 132 - * a list with balloon_page_push before removing them with balloon_page_pop. To 133 - * enqueue a list of pages, use balloon_page_list_enqueue instead. 131 + * Drivers must not enqueue pages while page->lru is still in 132 + * use, and must not use page->lru until a page was unqueued again. 134 133 */ 135 134 void balloon_page_enqueue(struct balloon_dev_info *b_dev_info, 136 135 struct page *page)