tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: amd: acp: Fix Kconfig dependencies for SND_SOC_ACPI_AMD_SDCA_QUIRKS

Fix the following kconfig warning reported by the kernel test robot:

kismet: WARNING: unmet direct dependencies detected for
SND_SOC_ACPI_AMD_SDCA_QUIRKS when selected by SND_SOC_ACPI_AMD_MATCH
Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] &&
ACPI [=y] && SND_SOC_SDCA [=n]
Selected by [y]:
- SND_SOC_ACPI_AMD_MATCH [=y] && SOUND [=y] && SND [=y] &&
SND_SOC [=y]

The issue occurs because SND_SOC_ACPI_AMD_SDCA_QUIRKS depends on
SND_SOC_SDCA, which may be disabled, causing unmet dependency warnings.
Fix this by adjusting the Kconfig dependency logic accordingly.

Fixes: e7c30ac379b4 ("ASoC: amd: acp: soc-acpi: add is_device_rt712_vb() helper")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601131155.RXGj4KHv-lkp@intel.com
Signed-off-by: Syed Saba Kareem <syed.sabakareem@amd.com>
Link: https://patch.msgid.link/20260123095524.490655-1-syed.sabakareem@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Syed Saba Kareem and committed by
Mark Brown 10d366a8 74120bc2

+15 -2
+2 -2
sound/soc/amd/acp/Kconfig
··· 15 15 16 16 config SND_SOC_ACPI_AMD_MATCH 17 17 tristate 18 - select SND_SOC_ACPI_AMD_SDCA_QUIRKS 19 - select SND_SOC_ACPI if ACPI 18 + select SND_SOC_ACPI_AMD_SDCA_QUIRKS if SND_SOC_SDCA 19 + select SND_SOC_ACPI if ACPI 20 20 21 21 config SND_SOC_ACPI_AMD_SDCA_QUIRKS 22 22 tristate
+2
sound/soc/amd/acp/amd-acp70-acpi-match.c
··· 376 376 MODULE_DESCRIPTION("AMD ACP7.0 & ACP7.1 tables and support for ACPI enumeration"); 377 377 MODULE_LICENSE("GPL"); 378 378 MODULE_AUTHOR("Vijendar.Mukunda@amd.com"); 379 + #if IS_ENABLED(CONFIG_SND_SOC_ACPI_AMD_SDCA_QUIRKS) 379 380 MODULE_IMPORT_NS("SND_SOC_ACPI_AMD_SDCA_QUIRKS"); 381 + #endif
+11
sound/soc/amd/acp/soc-acpi-amd-sdca-quirks.h
··· 9 9 #ifndef _SND_SOC_ACPI_AMD_SDCA_QUIRKS 10 10 #define _SND_SOC_ACPI_AMD_SDCA_QUIRKS 11 11 12 + #if IS_ENABLED(CONFIG_SND_SOC_ACPI_AMD_SDCA_QUIRKS) 13 + 12 14 bool snd_soc_acpi_amd_sdca_is_device_rt712_vb(void *arg); 15 + 16 + #else 17 + 18 + static inline bool snd_soc_acpi_amd_sdca_is_device_rt712_vb(void *arg) 19 + { 20 + return false; 21 + } 22 + 23 + #endif 13 24 14 25 #endif