tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

iio: light: adux1020: make use of regmap_clear_bits(), regmap_set_bits()

Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-28-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Trevor Gamblin and committed by
Jonathan Cameron 1131f1e7 0e59dc9e

+6 -7
+6 -7
drivers/iio/light/adux1020.c
··· 539 539 * Trigger proximity interrupt when the intensity is above 540 540 * or below threshold 541 541 */ 542 - ret = regmap_update_bits(data->regmap, ADUX1020_REG_PROX_TYPE, 543 - ADUX1020_PROX_TYPE, 544 - ADUX1020_PROX_TYPE); 542 + ret = regmap_set_bits(data->regmap, ADUX1020_REG_PROX_TYPE, 543 + ADUX1020_PROX_TYPE); 545 544 if (ret < 0) 546 545 goto fail; 547 546 ··· 747 748 748 749 dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val); 749 750 750 - ret = regmap_update_bits(data->regmap, ADUX1020_REG_SW_RESET, 751 - ADUX1020_SW_RESET, ADUX1020_SW_RESET); 751 + ret = regmap_set_bits(data->regmap, ADUX1020_REG_SW_RESET, 752 + ADUX1020_SW_RESET); 752 753 if (ret < 0) 753 754 return ret; 754 755 ··· 763 764 return ret; 764 765 765 766 /* Use LED_IREF for proximity mode */ 766 - ret = regmap_update_bits(data->regmap, ADUX1020_REG_LED_CURRENT, 767 - ADUX1020_LED_PIREF_EN, 0); 767 + ret = regmap_clear_bits(data->regmap, ADUX1020_REG_LED_CURRENT, 768 + ADUX1020_LED_PIREF_EN); 768 769 if (ret < 0) 769 770 return ret; 770 771