tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

dmaengine: pxa/mmp: stop referencing config->slave_id

The last driver referencing the slave_id on Marvell PXA and MMP platforms
was the SPI driver, but this stopped doing so a long time ago, so the
TODO from the earlier patch can no be removed.

Fixes: b729bf34535e ("spi/pxa2xx: Don't use slave_id of dma_slave_config")
Fixes: 13b3006b8ebd ("dma: mmp_pdma: add filter function")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20211122222203.4103644-7-arnd@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Arnd Bergmann and committed by
Vinod Koul 134c37fa 37228af8

-13
-6
drivers/dma/mmp_pdma.c
··· 727 727 728 728 chan->dir = direction; 729 729 chan->dev_addr = addr; 730 - /* FIXME: drivers should be ported over to use the filter 731 - * function. Once that's done, the following two lines can 732 - * be removed. 733 - */ 734 - if (cfg->slave_id) 735 - chan->drcmr = cfg->slave_id; 736 730 737 731 return 0; 738 732 }
-7
drivers/dma/pxa_dma.c
··· 909 909 *dcmd |= PXA_DCMD_BURST16; 910 910 else if (maxburst == 32) 911 911 *dcmd |= PXA_DCMD_BURST32; 912 - 913 - /* FIXME: drivers should be ported over to use the filter 914 - * function. Once that's done, the following two lines can 915 - * be removed. 916 - */ 917 - if (chan->cfg.slave_id) 918 - chan->drcmr = chan->cfg.slave_id; 919 912 } 920 913 921 914 static struct dma_async_tx_descriptor *