Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
platform/x86: thinkpad-lmi: Remove unused display_name member from struct tlmi_pwd_setting
The struct tlmi_pwd_setting display_name member is initialized,
but never read. Remove it and the TLMI_PWDTYPE_MAXLEN define.
While at it also remove some other unused [MAX]LEN defines.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210531135911.82582-1-hdegoede@redhat.com
-11
-2
drivers/platform/x86/think-lmi.c
-2
drivers/platform/x86/think-lmi.c
···
819
819
ret = -ENOMEM;
820
820
goto fail_clear_attr;
821
821
}
822
-
strscpy(tlmi_priv.pwd_admin->display_name, "admin", TLMI_PWDTYPE_MAXLEN);
823
822
strscpy(tlmi_priv.pwd_admin->kbdlang, "us", TLMI_LANG_MAXLEN);
824
823
tlmi_priv.pwd_admin->encoding = TLMI_ENCODING_ASCII;
825
824
tlmi_priv.pwd_admin->pwd_type = "pap";
···
835
836
ret = -ENOMEM;
836
837
goto fail_clear_attr;
837
838
}
838
-
strscpy(tlmi_priv.pwd_power->display_name, "power-on", TLMI_PWDTYPE_MAXLEN);
839
839
strscpy(tlmi_priv.pwd_power->kbdlang, "us", TLMI_LANG_MAXLEN);
840
840
tlmi_priv.pwd_power->encoding = TLMI_ENCODING_ASCII;
841
841
tlmi_priv.pwd_power->pwd_type = "pop";
-9
drivers/platform/x86/think-lmi.h
-9
drivers/platform/x86/think-lmi.h
···
8
8
#define TLMI_SETTINGS_COUNT 256
9
9
#define TLMI_SETTINGS_MAXLEN 512
10
10
#define TLMI_PWD_BUFSIZE 129
11
-
#define TLMI_PWDTYPE_MAXLEN 64
12
-
#define TLMI_ENC_MAXLEN 64
13
11
#define TLMI_LANG_MAXLEN 4
14
-
#define TLMI_PWDTYPE_LEN 4
15
-
/*
16
-
* Longest string should be in the set command: allow size of BIOS
17
-
* option and choice
18
-
*/
19
-
#define TLMI_GETSET_MAXLEN (TLMI_SETTINGS_MAXLEN + TLMI_SETTINGS_MAXLEN)
20
12
21
13
/* Possible error values */
22
14
struct tlmi_err_codes {
···
35
43
struct tlmi_pwd_setting {
36
44
struct kobject kobj;
37
45
bool valid;
38
-
char display_name[TLMI_PWDTYPE_MAXLEN];
39
46
char password[TLMI_PWD_BUFSIZE];
40
47
const char *pwd_type;
41
48
const char *role;