tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: Constify struct pci_error_handlers

'struct pci_error_handlers' are not modified in these drivers.

Constifying these structures moves some data to a read-only section, so
increase overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig, as an example:
Before:
======
text data bss dec hex filename
39049 6429 112 45590 b216 drivers/scsi/aacraid/linit.o

After:
=====
text data bss dec hex filename
39113 6365 112 45590 b216 drivers/scsi/aacraid/linit.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/efdec8425981e10fc398fa2ac599c9c45d930561.1737318548.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Christophe JAILLET and committed by
Martin K. Petersen 14807b4a 2014c95a

+8 -8
+1 -1
drivers/scsi/aacraid/linit.c
··· 2029 2029 dev_err(&pdev->dev, "aacraid: PCI error - resume\n"); 2030 2030 } 2031 2031 2032 - static struct pci_error_handlers aac_pci_err_handler = { 2032 + static const struct pci_error_handlers aac_pci_err_handler = { 2033 2033 .error_detected = aac_pci_error_detected, 2034 2034 .mmio_enabled = aac_pci_mmio_enabled, 2035 2035 .slot_reset = aac_pci_slot_reset,
+1 -1
drivers/scsi/be2iscsi/be_main.c
··· 5776 5776 } 5777 5777 5778 5778 5779 - static struct pci_error_handlers beiscsi_eeh_handlers = { 5779 + static const struct pci_error_handlers beiscsi_eeh_handlers = { 5780 5780 .error_detected = beiscsi_eeh_err_detected, 5781 5781 .slot_reset = beiscsi_eeh_reset, 5782 5782 .resume = beiscsi_eeh_resume,
+1 -1
drivers/scsi/bfa/bfad.c
··· 1642 1642 /* 1643 1643 * PCI error recovery handlers. 1644 1644 */ 1645 - static struct pci_error_handlers bfad_err_handler = { 1645 + static const struct pci_error_handlers bfad_err_handler = { 1646 1646 .error_detected = bfad_pci_error_detected, 1647 1647 .slot_reset = bfad_pci_slot_reset, 1648 1648 .mmio_enabled = bfad_pci_mmio_enabled,
+1 -1
drivers/scsi/csiostor/csio_init.c
··· 1162 1162 dev_err(&pdev->dev, "resume of device failed: %d\n", rv); 1163 1163 } 1164 1164 1165 - static struct pci_error_handlers csio_err_handler = { 1165 + static const struct pci_error_handlers csio_err_handler = { 1166 1166 .error_detected = csio_pci_error_detected, 1167 1167 .slot_reset = csio_pci_slot_reset, 1168 1168 .resume = csio_pci_resume,
+1 -1
drivers/scsi/elx/efct/efct_driver.c
··· 735 735 736 736 MODULE_DEVICE_TABLE(pci, efct_pci_table); 737 737 738 - static struct pci_error_handlers efct_pci_err_handler = { 738 + static const struct pci_error_handlers efct_pci_err_handler = { 739 739 .error_detected = efct_pci_io_error_detected, 740 740 .slot_reset = efct_pci_io_slot_reset, 741 741 .resume = efct_pci_io_resume,
+1 -1
drivers/scsi/mpi3mr/mpi3mr_os.c
··· 5803 5803 }; 5804 5804 MODULE_DEVICE_TABLE(pci, mpi3mr_pci_id_table); 5805 5805 5806 - static struct pci_error_handlers mpi3mr_err_handler = { 5806 + static const struct pci_error_handlers mpi3mr_err_handler = { 5807 5807 .error_detected = mpi3mr_pcierr_error_detected, 5808 5808 .mmio_enabled = mpi3mr_pcierr_mmio_enabled, 5809 5809 .slot_reset = mpi3mr_pcierr_slot_reset,
+1 -1
drivers/scsi/mpt3sas/mpt3sas_scsih.c
··· 12710 12710 }; 12711 12711 MODULE_DEVICE_TABLE(pci, mpt3sas_pci_table); 12712 12712 12713 - static struct pci_error_handlers _mpt3sas_err_handler = { 12713 + static const struct pci_error_handlers _mpt3sas_err_handler = { 12714 12714 .error_detected = scsih_pci_error_detected, 12715 12715 .mmio_enabled = scsih_pci_mmio_enabled, 12716 12716 .slot_reset = scsih_pci_slot_reset,
+1 -1
drivers/scsi/qedi/qedi_main.c
··· 2876 2876 2877 2877 static enum cpuhp_state qedi_cpuhp_state; 2878 2878 2879 - static struct pci_error_handlers qedi_err_handler = { 2879 + static const struct pci_error_handlers qedi_err_handler = { 2880 2880 .error_detected = qedi_io_error_detected, 2881 2881 }; 2882 2882