tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/msm: Pass along the format info from .fb_create() to drm_helper_mode_fill_fb_struct()

Plumb the format info from .fb_create() all the way to
drm_helper_mode_fill_fb_struct() to avoid the redundant
lookups.

For the fbdev case a manual drm_get_format_info() lookup
is needed.

Cc: Rob Clark <robdclark@gmail.com>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Dmitry Baryshkov <lumag@kernel.org>
Cc: Sean Paul <sean@poorly.run>
Cc: Marijn Suijten <marijn.suijten@somainline.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: freedreno@lists.freedesktop.org
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250701090722.13645-16-ville.syrjala@linux.intel.com

Ville Syrjälä 1506b103 7a46d039

+8 -6
+8 -6
drivers/gpu/drm/msm/msm_fb.c
··· 30 30 #define to_msm_framebuffer(x) container_of(x, struct msm_framebuffer, base) 31 31 32 32 static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, 33 + const struct drm_format_info *info, 33 34 const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_object **bos); 34 35 35 36 static int msm_framebuffer_dirtyfb(struct drm_framebuffer *fb, ··· 155 154 } 156 155 } 157 156 158 - fb = msm_framebuffer_init(dev, mode_cmd, bos); 157 + fb = msm_framebuffer_init(dev, info, mode_cmd, bos); 159 158 if (IS_ERR(fb)) { 160 159 ret = PTR_ERR(fb); 161 160 goto out_unref; ··· 170 169 } 171 170 172 171 static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, 172 + const struct drm_format_info *info, 173 173 const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_object **bos) 174 174 { 175 - const struct drm_format_info *info = drm_get_format_info(dev, 176 - mode_cmd->pixel_format, 177 - mode_cmd->modifier[0]); 178 175 struct msm_drm_private *priv = dev->dev_private; 179 176 struct msm_kms *kms = priv->kms; 180 177 struct msm_framebuffer *msm_fb = NULL; ··· 226 227 msm_fb->base.obj[i] = bos[i]; 227 228 } 228 229 229 - drm_helper_mode_fill_fb_struct(dev, fb, NULL, mode_cmd); 230 + drm_helper_mode_fill_fb_struct(dev, fb, info, mode_cmd); 230 231 231 232 ret = drm_framebuffer_init(dev, fb, &msm_framebuffer_funcs); 232 233 if (ret) { ··· 275 276 276 277 msm_gem_object_set_name(bo, "stolenfb"); 277 278 278 - fb = msm_framebuffer_init(dev, &mode_cmd, &bo); 279 + fb = msm_framebuffer_init(dev, 280 + drm_get_format_info(dev, mode_cmd.pixel_format, 281 + mode_cmd.modifier[0]), 282 + &mode_cmd, &bo); 279 283 if (IS_ERR(fb)) { 280 284 DRM_DEV_ERROR(dev->dev, "failed to allocate fb\n"); 281 285 /* note: if fb creation failed, we can't rely on fb destroy