tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

iio: adc: ad_sigma_delta: refactor setting read address

Refactor code to set the read address in a separate function.

This code is already duplicated twice and we will need to use it a third
time in a later commit.

Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250701-iio-adc-ad7173-add-spi-offload-support-v3-7-42abb83e3dac@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

David Lechner and committed by
Jonathan Cameron 1519bedf 86d8d6b8

+10 -6
+10 -6
drivers/iio/adc/ad_sigma_delta.c
··· 107 107 } 108 108 EXPORT_SYMBOL_NS_GPL(ad_sd_write_reg, "IIO_AD_SIGMA_DELTA"); 109 109 110 + static void ad_sd_set_read_reg_addr(struct ad_sigma_delta *sigma_delta, u8 reg, 111 + u8 *data) 112 + { 113 + data[0] = reg << sigma_delta->info->addr_shift; 114 + data[0] |= sigma_delta->info->read_mask; 115 + data[0] |= sigma_delta->comm; 116 + } 117 + 110 118 static int ad_sd_read_reg_raw(struct ad_sigma_delta *sigma_delta, 111 119 unsigned int reg, unsigned int size, u8 *val) 112 120 { ··· 135 127 spi_message_init(&m); 136 128 137 129 if (sigma_delta->info->has_registers) { 138 - data[0] = reg << sigma_delta->info->addr_shift; 139 - data[0] |= sigma_delta->info->read_mask; 140 - data[0] |= sigma_delta->comm; 130 + ad_sd_set_read_reg_addr(sigma_delta, reg, data); 141 131 spi_message_add_tail(&t[0], &m); 142 132 } 143 133 spi_message_add_tail(&t[1], &m); ··· 294 288 if (sigma_delta->info->has_registers) { 295 289 unsigned int data_reg = sigma_delta->info->data_reg ?: AD_SD_REG_DATA; 296 290 297 - data[0] = data_reg << sigma_delta->info->addr_shift; 298 - data[0] |= sigma_delta->info->read_mask; 299 - data[0] |= sigma_delta->comm; 291 + ad_sd_set_read_reg_addr(sigma_delta, data_reg, data); 300 292 t[0].tx_buf = data; 301 293 spi_message_add_tail(&t[0], &m); 302 294 }