tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

smackfs load append mode fix

Given just how hard it is to find the code that uses MAY_APPEND
it's probably not a big surprise that this went unnoticed for so
long. The Smack rules loading code is incorrectly setting the
MAY_READ bit when MAY_APPEND is requested.

Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
Reviewed-by: James Morris <jmorris@namei.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Casey Schaufler and committed by
Linus Torvalds 152a649b e4a7ca29

+1 -1
+1 -1
security/smack/smackfs.c
··· 334 334 break; 335 335 case 'a': 336 336 case 'A': 337 - rule.smk_access |= MAY_READ; 337 + rule.smk_access |= MAY_APPEND; 338 338 break; 339 339 default: 340 340 goto out;