Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/amdgpu/userq: drop VCN and VPE doorbell handling

VCN and VPE userqs are not yet supported and this code is
not correct. Userspace should provide the correct
doorbell offset with in their doorbell page for the IP.
Adjusting it here will not work as expected as userspace
and the queue itself will have different offsets.

We need to add a INFO IOCTL query to get the offset and
range for each IP within the doorbell page to handle this
properly.

Cc: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
Reviewed-by: Saleemkhan Jamadar <saleemkhan.jamadar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

-11
-11
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
··· 417 417 case AMDGPU_HW_IP_DMA: 418 418 db_size = sizeof(u64); 419 419 break; 420 - 421 - case AMDGPU_HW_IP_VCN_ENC: 422 - db_size = sizeof(u32); 423 - db_info->doorbell_offset += AMDGPU_NAVI10_DOORBELL64_VCN0_1 << 1; 424 - break; 425 - 426 - case AMDGPU_HW_IP_VPE: 427 - db_size = sizeof(u32); 428 - db_info->doorbell_offset += AMDGPU_NAVI10_DOORBELL64_VPE << 1; 429 - break; 430 - 431 420 default: 432 421 drm_file_err(uq_mgr->file, "[Usermode queues] IP %d not support\n", 433 422 db_info->queue_type);