Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
perf x86 evlist: Update comments on topdown regrouping
Update to remove comments about groupings not working and with the:
```
perf stat -e "{instructions,slots},{cycles,topdown-retiring}"
```
case that now works.
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Signed-off-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250307023906.1135613-4-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
authored by
Dapeng Mi
and committed by
Namhyung Kim
16dd43df
9a1c57fe
+6
-21
+6
-21
tools/perf/arch/x86/util/evlist.c
+6
-21
tools/perf/arch/x86/util/evlist.c
···
39
39
* 26,319,024 slots
40
40
* 2,427,791 instructions
41
41
* 2,683,508 topdown-retiring
42
-
*
43
-
* If slots event and topdown metrics events are not in same group, the
44
-
* topdown metrics events must be first event after the slots event group,
45
-
* otherwise topdown metrics events can't be regrouped correctly, e.g.
46
-
*
47
-
* a. perf stat -e "{instructions,slots},cycles,topdown-retiring" -C0 sleep 1
42
+
* e. slots event and metrics event are not in a group and not adjacent
43
+
* perf stat -e "{instructions,slots},cycles,topdown-retiring" -C0 sleep 1
48
44
* WARNING: events were regrouped to match PMUs
49
-
* Performance counter stats for 'CPU(s) 0':
50
-
* 17,923,134 slots
51
-
* 2,154,855 instructions
52
-
* 3,015,058 cycles
53
-
* <not supported> topdown-retiring
54
-
*
55
-
* If slots event and topdown metrics events are in two groups, the group which
56
-
* has topdown metrics events must contain only the topdown metrics event,
57
-
* otherwise topdown metrics event can't be regrouped correctly as well, e.g.
58
-
*
59
-
* a. perf stat -e "{instructions,slots},{topdown-retiring,cycles}" -C0 sleep 1
60
-
* WARNING: events were regrouped to match PMUs
61
-
* Error:
62
-
* The sys_perf_event_open() syscall returned with 22 (Invalid argument) for
63
-
* event (topdown-retiring)
45
+
* 68,433,522 slots
46
+
* 8,856,102 topdown-retiring
47
+
* 7,791,494 instructions
48
+
* 11,469,513 cycles
64
49
*/
65
50
if (topdown_sys_has_perf_metrics() &&
66
51
(arch_evsel__must_be_in_group(lhs) || arch_evsel__must_be_in_group(rhs))) {