Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: Remove unneeded break statements

A break is not needed if it is preceded by a return or goto.

Link: https://lore.kernel.org/r/20201019142333.16584-1-trix@redhat.com
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Tom Rix and committed by
Martin K. Petersen
170b7d2d 434ee425

+4 -31
-1
drivers/scsi/aic94xx/aic94xx_task.c
··· 269 269 case TA_I_T_NEXUS_LOSS: 270 270 opcode = dl->status_block[0]; 271 271 goto Again; 272 - break; 273 272 case TF_INV_CONN_HANDLE: 274 273 ts->resp = SAS_TASK_UNDELIVERED; 275 274 ts->stat = SAS_DEVICE_UNKNOWN;
-4
drivers/scsi/be2iscsi/be_mgmt.c
··· 1244 1244 case OC_DEVICE_ID2: 1245 1245 return snprintf(buf, PAGE_SIZE, 1246 1246 "Obsolete/Unsupported BE2 Adapter Family\n"); 1247 - break; 1248 1247 case BE_DEVICE_ID2: 1249 1248 case OC_DEVICE_ID3: 1250 1249 return snprintf(buf, PAGE_SIZE, "BE3-R Adapter Family\n"); 1251 - break; 1252 1250 case OC_SKH_ID1: 1253 1251 return snprintf(buf, PAGE_SIZE, "Skyhawk-R Adapter Family\n"); 1254 - break; 1255 1252 default: 1256 1253 return snprintf(buf, PAGE_SIZE, 1257 1254 "Unknown Adapter Family: 0x%x\n", dev_id); 1258 - break; 1259 1255 } 1260 1256 } 1261 1257
-1
drivers/scsi/bnx2fc/bnx2fc_hwi.c
··· 770 770 } else 771 771 printk(KERN_ERR PFX "SRR in progress\n"); 772 772 goto ret_err_rqe; 773 - break; 774 773 default: 775 774 break; 776 775 }
-1
drivers/scsi/fcoe/fcoe.c
··· 1894 1894 mutex_unlock(&fcoe_config_mutex); 1895 1895 fcoe_ctlr_device_delete(fcoe_ctlr_to_ctlr_dev(ctlr)); 1896 1896 goto out; 1897 - break; 1898 1897 case NETDEV_FEAT_CHANGE: 1899 1898 fcoe_netdev_features_change(lport, netdev); 1900 1899 break;
-1
drivers/scsi/hpsa.c
··· 7442 7442 dev_warn(&pdev->dev, 7443 7443 "base address is invalid\n"); 7444 7444 return -1; 7445 - break; 7446 7445 } 7447 7446 } 7448 7447 if (offset == pci_bar_addr - PCI_BASE_ADDRESS_0)
-1
drivers/scsi/hptiop.c
··· 758 758 scp->result = SAM_STAT_CHECK_CONDITION; 759 759 memcpy(scp->sense_buffer, &req->sg_list, SCSI_SENSE_BUFFERSIZE); 760 760 goto skip_resid; 761 - break; 762 761 763 762 default: 764 763 scp->result = DRIVER_INVALID << 24 | DID_ABORT << 16;
-1
drivers/scsi/ipr.c
··· 9487 9487 case pci_channel_io_perm_failure: 9488 9488 ipr_pci_perm_failure(pdev); 9489 9489 return PCI_ERS_RESULT_DISCONNECT; 9490 - break; 9491 9490 default: 9492 9491 break; 9493 9492 }
-2
drivers/scsi/isci/phy.c
··· 753 753 default: 754 754 phy_event_warn(iphy, state, event_code); 755 755 return SCI_FAILURE; 756 - break; 757 756 } 758 757 return SCI_SUCCESS; 759 758 case SCI_PHY_SUB_AWAIT_IAF_UF: ··· 957 958 default: 958 959 phy_event_warn(iphy, state, event_code); 959 960 return SCI_FAILURE_INVALID_STATE; 960 - break; 961 961 } 962 962 return SCI_SUCCESS; 963 963 default:
+4 -8
drivers/scsi/lpfc/lpfc_debugfs.c
··· 3341 3341 break; 3342 3342 case LPFC_PCI_CFG_BROWSE: /* browse all */ 3343 3343 goto pcicfg_browse; 3344 - break; 3345 3344 default: 3346 3345 /* illegal count */ 3347 3346 len = 0; ··· 4380 4381 } 4381 4382 } 4382 4383 goto error_out; 4383 - break; 4384 + 4384 4385 case LPFC_IDIAG_CQ: 4385 4386 /* MBX complete queue */ 4386 4387 if (phba->sli4_hba.mbx_cq && ··· 4432 4433 } 4433 4434 } 4434 4435 goto error_out; 4435 - break; 4436 + 4436 4437 case LPFC_IDIAG_MQ: 4437 4438 /* MBX work queue */ 4438 4439 if (phba->sli4_hba.mbx_wq && ··· 4446 4447 goto pass_check; 4447 4448 } 4448 4449 goto error_out; 4449 - break; 4450 + 4450 4451 case LPFC_IDIAG_WQ: 4451 4452 /* ELS work queue */ 4452 4453 if (phba->sli4_hba.els_wq && ··· 4486 4487 } 4487 4488 } 4488 4489 } 4489 - 4490 4490 goto error_out; 4491 - break; 4491 + 4492 4492 case LPFC_IDIAG_RQ: 4493 4493 /* HDR queue */ 4494 4494 if (phba->sli4_hba.hdr_rq && ··· 4512 4514 goto pass_check; 4513 4515 } 4514 4516 goto error_out; 4515 - break; 4516 4517 default: 4517 4518 goto error_out; 4518 - break; 4519 4519 } 4520 4520 4521 4521 pass_check:
-1
drivers/scsi/lpfc/lpfc_init.c
··· 7196 7196 "1431 Invalid HBA PCI-device group: 0x%x\n", 7197 7197 dev_grp); 7198 7198 return -ENODEV; 7199 - break; 7200 7199 } 7201 7200 return 0; 7202 7201 }
-1
drivers/scsi/lpfc/lpfc_scsi.c
··· 4284 4284 "1418 Invalid HBA PCI-device group: 0x%x\n", 4285 4285 dev_grp); 4286 4286 return -ENODEV; 4287 - break; 4288 4287 } 4289 4288 phba->lpfc_rampdown_queue_depth = lpfc_rampdown_queue_depth; 4290 4289 phba->lpfc_scsi_cmd_iocb_cmpl = lpfc_scsi_cmd_iocb_cmpl;
-3
drivers/scsi/lpfc/lpfc_sli.c
··· 9189 9189 "1420 Invalid HBA PCI-device group: 0x%x\n", 9190 9190 dev_grp); 9191 9191 return -ENODEV; 9192 - break; 9193 9192 } 9194 9193 return 0; 9195 9194 } ··· 10071 10072 "2014 Invalid command 0x%x\n", 10072 10073 iocbq->iocb.ulpCommand); 10073 10074 return IOCB_ERROR; 10074 - break; 10075 10075 } 10076 10076 10077 10077 if (iocbq->iocb_flag & LPFC_IO_DIF_PASS) ··· 10232 10234 "1419 Invalid HBA PCI-device group: 0x%x\n", 10233 10235 dev_grp); 10234 10236 return -ENODEV; 10235 - break; 10236 10237 } 10237 10238 phba->lpfc_get_iocb_from_iocbq = lpfc_get_iocb_from_iocbq; 10238 10239 return 0;
-1
drivers/scsi/mvumi.c
··· 2296 2296 break; 2297 2297 default: 2298 2298 return -1; 2299 - break; 2300 2299 } 2301 2300 2302 2301 return 0;
-2
drivers/scsi/pcmcia/nsp_cs.c
··· 1102 1102 nsp_index_write(base, SCSIBUSCTRL, SCSI_ATN | AUTODIRECTION | ACKENB); 1103 1103 return IRQ_HANDLED; 1104 1104 1105 - break; 1106 - 1107 1105 case PH_RESELECT: 1108 1106 //nsp_dbg(NSP_DEBUG_INTR, "phase reselect"); 1109 1107 // *sync_neg = SYNC_NOT_YET;
-1
drivers/scsi/qla2xxx/qla_mbx.c
··· 4030 4030 4031 4031 set_bit(N2N_LOGIN_NEEDED, &vha->dpc_flags); 4032 4032 return; 4033 - break; 4034 4033 case TOPO_FL: 4035 4034 ha->current_topology = ISP_CFG_FL; 4036 4035 break;
-1
drivers/scsi/st.c
··· 2846 2846 case MTNOP: 2847 2847 DEBC_printk(STp, "No op on tape.\n"); 2848 2848 return 0; /* Should do something ? */ 2849 - break; 2850 2849 case MTRETEN: 2851 2850 cmd[0] = START_STOP; 2852 2851 if (STp->immediate) {
-1
drivers/scsi/sym53c8xx_2/sym_hipd.c
··· 4596 4596 scr_to_cpu(np->lastmsg), np->msgout[0]); 4597 4597 } 4598 4598 goto out_clrack; 4599 - break; 4600 4599 default: 4601 4600 goto out_reject; 4602 4601 }