tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

eth: bnxt: fix string truncation warning in FW version

W=1 builds with gcc 14.2.1 report:

drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:4193:32: error: ‘%s’ directive output may be truncated writing up to 31 bytes into a region of size 27 [-Werror=format-truncation=]
4193 | "/pkg %s", buf);

It's upset that we let buf be full length but then we use 5
characters for "/pkg ".

The builds is also clear with clang version 19.1.5 now.

Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250117183726.1481524-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Jakub Kicinski 17656eb5 5b4fd353

+1 -1
+1 -1
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
··· 4184 4184 static void bnxt_get_pkgver(struct net_device *dev) 4185 4185 { 4186 4186 struct bnxt *bp = netdev_priv(dev); 4187 - char buf[FW_VER_STR_LEN]; 4187 + char buf[FW_VER_STR_LEN - 5]; 4188 4188 int len; 4189 4189 4190 4190 if (!bnxt_get_pkginfo(dev, buf, sizeof(buf))) {