tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: ag71xx: use phylink_mii_ioctl

f1294617d2f38bd2b9f6cce516b0326858b61182 removed the custom function for
ndo_eth_ioctl and used the standard phy_do_ioctl which calls
phy_mii_ioctl. However since then, this driver was ported to phylink
where it makes more sense to call phylink_mii_ioctl.

Bring back custom function that calls phylink_mii_ioctl.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20240807215834.33980-1-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Rosen Penev and committed by
Jakub Kicinski 1862923b c89c6757

+8 -1
+8 -1
drivers/net/ethernet/atheros/ag71xx.c
··· 447 447 ag71xx_cb(ag, AG71XX_REG_INT_ENABLE, ints); 448 448 } 449 449 450 + static int ag71xx_do_ioctl(struct net_device *ndev, struct ifreq *ifr, int cmd) 451 + { 452 + struct ag71xx *ag = netdev_priv(ndev); 453 + 454 + return phylink_mii_ioctl(ag->phylink, ifr, cmd); 455 + } 456 + 450 457 static void ag71xx_get_drvinfo(struct net_device *ndev, 451 458 struct ethtool_drvinfo *info) 452 459 { ··· 1806 1799 .ndo_open = ag71xx_open, 1807 1800 .ndo_stop = ag71xx_stop, 1808 1801 .ndo_start_xmit = ag71xx_hard_start_xmit, 1809 - .ndo_eth_ioctl = phy_do_ioctl, 1802 + .ndo_eth_ioctl = ag71xx_do_ioctl, 1810 1803 .ndo_tx_timeout = ag71xx_tx_timeout, 1811 1804 .ndo_change_mtu = ag71xx_change_mtu, 1812 1805 .ndo_set_mac_address = eth_mac_addr,