tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

tty: replace use of system_unbound_wq with system_dfl_wq

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistentcy cannot be addressed without refactoring the API.

This patch continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

system_dfl_wq should be the default workqueue so as not to enforce
locality constraints for random work whenever it's not required.

The old system_unbound_wq will be kept for a few release cycles.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20251104105446.110884-1-marco.crivellari@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Marco Crivellari and committed by
Greg Kroah-Hartman 1879c2e4 da218406

+6 -6
+2 -2
drivers/tty/serial/8250/8250_dw.c
··· 361 361 * deferred event handling complication. 362 362 */ 363 363 if (event == POST_RATE_CHANGE) { 364 - queue_work(system_unbound_wq, &d->clk_work); 364 + queue_work(system_dfl_wq, &d->clk_work); 365 365 return NOTIFY_OK; 366 366 } 367 367 ··· 680 680 err = clk_notifier_register(data->clk, &data->clk_notifier); 681 681 if (err) 682 682 return dev_err_probe(dev, err, "Failed to set the clock notifier\n"); 683 - queue_work(system_unbound_wq, &data->clk_work); 683 + queue_work(system_dfl_wq, &data->clk_work); 684 684 } 685 685 686 686 platform_set_drvdata(pdev, data);
+4 -4
drivers/tty/tty_buffer.c
··· 76 76 mutex_unlock(&buf->lock); 77 77 78 78 if (restart) 79 - queue_work(system_unbound_wq, &buf->work); 79 + queue_work(system_dfl_wq, &buf->work); 80 80 } 81 81 EXPORT_SYMBOL_GPL(tty_buffer_unlock_exclusive); 82 82 ··· 530 530 struct tty_bufhead *buf = &port->buf; 531 531 532 532 tty_flip_buffer_commit(buf->tail); 533 - queue_work(system_unbound_wq, &buf->work); 533 + queue_work(system_dfl_wq, &buf->work); 534 534 } 535 535 EXPORT_SYMBOL(tty_flip_buffer_push); 536 536 ··· 560 560 tty_flip_buffer_commit(buf->tail); 561 561 spin_unlock_irqrestore(&port->lock, flags); 562 562 563 - queue_work(system_unbound_wq, &buf->work); 563 + queue_work(system_dfl_wq, &buf->work); 564 564 565 565 return size; 566 566 } ··· 613 613 614 614 bool tty_buffer_restart_work(struct tty_port *port) 615 615 { 616 - return queue_work(system_unbound_wq, &port->buf.work); 616 + return queue_work(system_dfl_wq, &port->buf.work); 617 617 } 618 618 619 619 bool tty_buffer_cancel_work(struct tty_port *port)