Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/omap: cleanup OMAP_BO_SCANOUT use
omap_gem_new() has a comment about OMAP_BO_SCANOUT which does not make
sense. Also, for the TILER case, we drop OMAP_BO_SCANOUT flag for some
reason.
It's not clear what the original purpose of OMAP_BO_SCANOUT is, but
presuming it means "scanout buffer, something that can be consumed by
DSS", this patch cleans up the above issues.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191010120000.1421-7-jjhiblot@ti.com
+2
-4
+2
-4
drivers/gpu/drm/omapdrm/omap_gem.c
+2
-4
drivers/gpu/drm/omapdrm/omap_gem.c
···
1155
1155
* Tiled buffers are always shmem paged backed. When they are
1156
1156
* scanned out, they are remapped into DMM/TILER.
1157
1157
*/
1158
-
flags &= ~OMAP_BO_SCANOUT;
1159
1158
flags |= OMAP_BO_MEM_SHMEM;
1160
1159
1161
1160
/*
···
1165
1166
flags |= tiler_get_cpu_cache_flags();
1166
1167
} else if ((flags & OMAP_BO_SCANOUT) && !priv->has_dmm) {
1167
1168
/*
1168
-
* OMAP_BO_SCANOUT hints that the buffer doesn't need to be
1169
-
* tiled. However, to lower the pressure on memory allocation,
1170
-
* use contiguous memory only if no TILER is available.
1169
+
* If we don't have DMM, we must allocate scanout buffers
1170
+
* from contiguous DMA memory.
1171
1171
*/
1172
1172
flags |= OMAP_BO_MEM_DMA_API;
1173
1173
} else if (!(flags & OMAP_BO_MEM_DMABUF)) {