tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

rtc: amlogic-a4: Remove IRQF_ONESHOT

Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.
The flag also disallows force-threading of the primary handler and the
irq-core will warn about this.

Remove IRQF_ONESHOT from irqflags.

Fixes: c89ac9182ee29 ("rtc: support for the Amlogic on-chip RTC")
Reviewed-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: https://patch.msgid.link/20260128095540.863589-13-bigeasy@linutronix.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Sebastian Andrzej Siewior and committed by
Alexandre Belloni 1932db20 a380a02e

+1 -1
+1 -1
drivers/rtc/rtc-amlogic-a4.c
··· 369 369 return PTR_ERR(rtc->rtc_dev); 370 370 371 371 ret = devm_request_irq(dev, rtc->irq, aml_rtc_handler, 372 - IRQF_ONESHOT, "aml-rtc alarm", rtc); 372 + 0, "aml-rtc alarm", rtc); 373 373 if (ret) { 374 374 dev_err_probe(dev, ret, "IRQ%d request failed, ret = %d\n", 375 375 rtc->irq, ret);