-2

drivers/md/dm-vdo/block-map.c

reviewed

··· 209 209 /** 210 210 * allocate_cache_components() - Allocate components of the cache which require their own 211 211 * allocation. 212 212 - * @maximum_age: The number of journal blocks before a dirtied page is considered old and must be 213 213 - * written out. 214 212 * 215 213 * The caller is responsible for all clean up on errors. 216 214 *

+4 -3

drivers/md/dm-vdo/data-vio.c

reviewed

··· 327 327 328 328 /** 329 329 * set_data_vio_compression_status() - Set the compression status of a data_vio. 330 330 - * @state: The expected current status of the data_vio. 331 331 - * @new_state: The status to set. 330 330 + * @data_vio: The data_vio to change. 331 331 + * @status: The expected current status of the data_vio. 332 332 + * @new_status: The status to set. 332 333 * 333 334 * Return: true if the new status was set, false if the data_vio's compression status did not 334 335 * match the expected state, and so was left unchanged. ··· 837 836 * @vdo: The vdo to which the pool will belong. 838 837 * @pool_size: The number of data_vios in the pool. 839 838 * @discard_limit: The maximum number of data_vios which may be used for discards. 840 840 - * @pool: A pointer to hold the newly allocated pool. 839 839 + * @pool_ptr: A pointer to hold the newly allocated pool. 841 840 */ 842 841 int make_data_vio_pool(struct vdo *vdo, data_vio_count_t pool_size, 843 842 data_vio_count_t discard_limit, struct data_vio_pool **pool_ptr)

+5 -4

drivers/md/dm-vdo/dedupe.c

reviewed

··· 565 565 * @waiter: The data_vio's waiter link. 566 566 * @context: Not used. 567 567 */ 568 568 - static void abort_waiter(struct vdo_waiter *waiter, void *context __always_unused) 568 568 + static void abort_waiter(struct vdo_waiter *waiter, void __always_unused *context) 569 569 { 570 570 write_data_vio(vdo_waiter_as_data_vio(waiter)); 571 571 } ··· 1727 1727 /** 1728 1728 * vdo_continue_hash_lock() - Continue the processing state after writing, compressing, or 1729 1729 * deduplicating. 1730 1730 - * @data_vio: The data_vio to continue processing in its hash lock. 1730 1730 + * @completion: The data_vio completion to continue processing in its hash lock. 1731 1731 * 1732 1732 * Asynchronously continue processing a data_vio in its hash lock after it has finished writing, 1733 1733 * compressing, or deduplicating, so it can share the result with any data_vios waiting in the hash ··· 1825 1825 1826 1826 /** 1827 1827 * vdo_acquire_hash_lock() - Acquire or share a lock on a record name. 1828 1828 - * @data_vio: The data_vio acquiring a lock on its record name. 1828 1828 + * @completion: The data_vio completion acquiring a lock on its record name. 1829 1829 * 1830 1830 * Acquire or share a lock on the hash (record name) of the data in a data_vio, updating the 1831 1831 * data_vio to reference the lock. This must only be called in the correct thread for the zone. In ··· 2679 2679 2680 2680 /** 2681 2681 * vdo_get_dedupe_statistics() - Tally the statistics from all the hash zones and the UDS index. 2682 2682 - * @hash_zones: The hash zones to query 2682 2682 + * @zones: The hash zones to query 2683 2683 + * @stats: A structure to store the statistics 2683 2684 * 2684 2685 * Return: The sum of the hash lock statistics from all hash zones plus the statistics from the UDS 2685 2686 * index

+1 -1

drivers/md/dm-vdo/encodings.c

reviewed

··· 858 858 /** 859 859 * vdo_initialize_layout() - Lay out the partitions of a vdo. 860 860 * @size: The entire size of the vdo. 861 861 - * @origin: The start of the layout on the underlying storage in blocks. 861 861 + * @offset: The start of the layout on the underlying storage in blocks. 862 862 * @block_map_blocks: The size of the block map partition. 863 863 * @journal_blocks: The size of the journal partition. 864 864 * @summary_blocks: The size of the slab summary partition.

+1 -1

drivers/md/dm-vdo/io-submitter.c

reviewed

··· 367 367 * completions. 368 368 * @max_requests_active: Number of bios for merge tracking. 369 369 * @vdo: The vdo which will use this submitter. 370 370 - * @io_submitter: pointer to the new data structure. 370 370 + * @io_submitter_ptr: pointer to the new data structure. 371 371 * 372 372 * Return: VDO_SUCCESS or an error. 373 373 */

+1 -2

drivers/md/dm-vdo/packer.c

reviewed

··· 250 250 /** 251 251 * release_compressed_write_waiter() - Update a data_vio for which a successful compressed write 252 252 * has completed and send it on its way. 253 253 - 254 253 * @data_vio: The data_vio to release. 255 254 * @allocation: The allocation to which the compressed block was written. 256 255 */ ··· 382 383 * @compression: The agent's compression_state to pack in to. 383 384 * @data_vio: The data_vio to pack. 384 385 * @offset: The offset into the compressed block at which to pack the fragment. 385 385 - * @compressed_block: The compressed block which will be written out when batch is fully packed. 386 386 + * @block: The compressed block which will be written out when batch is fully packed. 386 387 * 387 388 * Return: The new amount of space used. 388 389 */

+1 -1

drivers/md/dm-vdo/physical-zone.c

reviewed

··· 517 517 * @waiter: The allocating_vio that was waiting to allocate. 518 518 * @context: The context (unused). 519 519 */ 520 520 - static void retry_allocation(struct vdo_waiter *waiter, void *context __always_unused) 520 520 + static void retry_allocation(struct vdo_waiter *waiter, void __always_unused *context) 521 521 { 522 522 struct data_vio *data_vio = vdo_waiter_as_data_vio(waiter); 523 523

+1 -1

drivers/md/dm-vdo/recovery-journal.c

reviewed

··· 1365 1365 * 1366 1366 * Implements waiter_callback_fn. 1367 1367 */ 1368 1368 - static void write_block(struct vdo_waiter *waiter, void *context __always_unused) 1368 1368 + static void write_block(struct vdo_waiter *waiter, void __always_unused *context) 1369 1369 { 1370 1370 struct recovery_journal_block *block = 1371 1371 container_of(waiter, struct recovery_journal_block, write_waiter);

+3 -6

drivers/md/dm-vdo/slab-depot.c

reviewed

··· 1287 1287 * slab_block_number_from_pbn() - Determine the index within the slab of a particular physical 1288 1288 * block number. 1289 1289 * @slab: The slab. 1290 1290 - * @physical_block_number: The physical block number. 1290 1290 + * @pbn: The physical block number. 1291 1291 * @slab_block_number_ptr: A pointer to the slab block number. 1292 1292 * 1293 1293 * Return: VDO_SUCCESS or an error code. ··· 1459 1459 * @block_number: The block to update. 1460 1460 * @old_status: The reference status of the data block before this decrement. 1461 1461 * @updater: The reference updater doing this operation in case we need to look up the pbn lock. 1462 1462 - * @lock: The pbn_lock associated with the block being decremented (may be NULL). 1463 1462 * @counter_ptr: A pointer to the count for the data block (in, out). 1464 1463 * @adjust_block_count: Whether to update the allocator's free block count. 1465 1464 * ··· 3231 3232 /** 3232 3233 * vdo_modify_reference_count() - Modify the reference count of a block by first making a slab 3233 3234 * journal entry and then updating the reference counter. 3234 3234 - * 3235 3235 - * @data_vio: The data_vio for which to add the entry. 3235 3235 + * @completion: The data_vio completion for which to add the entry. 3236 3236 * @updater: Which of the data_vio's reference updaters is being submitted. 3237 3237 */ 3238 3238 void vdo_modify_reference_count(struct vdo_completion *completion, ··· 4748 4750 /** 4749 4751 * stop_scrubbing() - Tell the scrubber to stop scrubbing after it finishes the slab it is 4750 4752 * currently working on. 4751 4751 - * @scrubber: The scrubber to stop. 4752 4752 - * @parent: The completion to notify when scrubbing has stopped. 4753 4753 + * @allocator: The block allocator owning the scrubber to stop. 4753 4754 */ 4754 4755 static void stop_scrubbing(struct block_allocator *allocator) 4755 4756 {

+2 -2

drivers/md/dm-vdo/vdo.c

reviewed

··· 643 643 644 644 /** 645 645 * free_listeners() - Free the list of read-only listeners associated with a thread. 646 646 - * @thread_data: The thread holding the list to free. 646 646 + * @thread: The thread holding the list to free. 647 647 */ 648 648 static void free_listeners(struct vdo_thread *thread) 649 649 { ··· 852 852 /** 853 853 * vdo_get_state() - Get the current state of the vdo. 854 854 * @vdo: The vdo. 855 855 - 855 855 + * 856 856 * Context: This method may be called from any thread. 857 857 * 858 858 * Return: The current state of the vdo.