tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

interconnect: qcom: bcm-voter: Use enable_maks for keepalive voting

BCMs with an enable_mask expect to only have that specific value written
to them. The current implementation only works by miracle for BCMs with
enable mask == BIT(0), as the minimal vote we've been using so far just
so happens to be equal to that.

Use the correct value with keepalive voting.

Fixes: d8630f050d3f ("interconnect: qcom: Add support for mask-based BCMs")
Reported-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230811-topic-icc_fix_1he-v2-2-0620af8ac133@linaro.org
Signed-off-by: Georgi Djakov <djakov@kernel.org>

authored by

Konrad Dybcio and committed by
Georgi Djakov 1a70ca71 a1f4170d

+4 -4
+4 -4
drivers/interconnect/qcom/bcm-voter.c
··· 81 81 } 82 82 83 83 if (bcm->keepalive) { 84 - bcm->vote_x[QCOM_ICC_BUCKET_AMC] = 1; 85 - bcm->vote_x[QCOM_ICC_BUCKET_WAKE] = 1; 86 - bcm->vote_y[QCOM_ICC_BUCKET_AMC] = 1; 87 - bcm->vote_y[QCOM_ICC_BUCKET_WAKE] = 1; 84 + bcm->vote_x[QCOM_ICC_BUCKET_AMC] = bcm->enable_mask; 85 + bcm->vote_x[QCOM_ICC_BUCKET_WAKE] = bcm->enable_mask; 86 + bcm->vote_y[QCOM_ICC_BUCKET_AMC] = bcm->enable_mask; 87 + bcm->vote_y[QCOM_ICC_BUCKET_WAKE] = bcm->enable_mask; 88 88 } 89 89 } 90 90