Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
Merge tag 'auxdisplay-for-linus-v4.16-rc6' of git://github.com/ojeda/linux
Pull auxdisplay fixes from Miguel Ojeda:
"Silence a few warnings in auxdisplay.
- a couple of uninitialized warnings reported by the build service
- a doc comment warning under W=1
- three fall-through comments not recognized under W=1"
* tag 'auxdisplay-for-linus-v4.16-rc6' of git://github.com/ojeda/linux:
auxdisplay: img-ascii-lcd: Silence 2 uninitialized warnings
auxdisplay: img-ascii-lcd: Fix doc comment to silence warnings
auxdisplay: panel: Change comments to silence fallthrough warnings
+6
-6
+3
-3
drivers/auxdisplay/img-ascii-lcd.c
+3
-3
drivers/auxdisplay/img-ascii-lcd.c
···
97
97
static void malta_update(struct img_ascii_lcd_ctx *ctx)
98
98
{
99
99
unsigned int i;
100
-
int err;
100
+
int err = 0;
101
101
102
102
for (i = 0; i < ctx->cfg->num_chars; i++) {
103
103
err = regmap_write(ctx->regmap,
···
180
180
static void sead3_update(struct img_ascii_lcd_ctx *ctx)
181
181
{
182
182
unsigned int i;
183
-
int err;
183
+
int err = 0;
184
184
185
185
for (i = 0; i < ctx->cfg->num_chars; i++) {
186
186
err = sead3_wait_lcd_idle(ctx);
···
224
224
225
225
/**
226
226
* img_ascii_lcd_scroll() - scroll the display by a character
227
-
* @arg: really a pointer to the private data structure
227
+
* @t: really a pointer to the private data structure
228
228
*
229
229
* Scroll the current message along the LCD by one character, rearming the
230
230
* timer if required.
+3
-3
drivers/auxdisplay/panel.c
+3
-3
drivers/auxdisplay/panel.c
···
1372
1372
break;
1373
1373
input->rise_timer = 0;
1374
1374
input->state = INPUT_ST_RISING;
1375
-
/* no break here, fall through */
1375
+
/* fall through */
1376
1376
case INPUT_ST_RISING:
1377
1377
if ((phys_curr & input->mask) != input->value) {
1378
1378
input->state = INPUT_ST_LOW;
···
1385
1385
}
1386
1386
input->high_timer = 0;
1387
1387
input->state = INPUT_ST_HIGH;
1388
-
/* no break here, fall through */
1388
+
/* fall through */
1389
1389
case INPUT_ST_HIGH:
1390
1390
if (input_state_high(input))
1391
1391
break;
1392
-
/* no break here, fall through */
1392
+
/* fall through */
1393
1393
case INPUT_ST_FALLING:
1394
1394
input_state_falling(input);
1395
1395
}