tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

USB: core: Discard pm_runtime_put() return value

To allow the return type of pm_runtime_put() to be changed to void in the
future, modify usb_autopm_put_interface_async() to discard the return
value of pm_runtime_put().

That value is merely used in a debug comment printed by the function in
question and it is not a particularly useful piece of information
because pm_runtime_put() does not guarantee that the device will be
suspended even if it successfully queues up a work item to check
whether or not the device can be suspended.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/5058509.GXAFRqVoOG@rafael.j.wysocki

Rafael J. Wysocki 1ade6a4f 9ace4753

+3 -5
+3 -5
drivers/usb/core/driver.c
··· 1810 1810 void usb_autopm_put_interface_async(struct usb_interface *intf) 1811 1811 { 1812 1812 struct usb_device *udev = interface_to_usbdev(intf); 1813 - int status; 1814 1813 1815 1814 usb_mark_last_busy(udev); 1816 - status = pm_runtime_put(&intf->dev); 1817 - dev_vdbg(&intf->dev, "%s: cnt %d -> %d\n", 1818 - __func__, atomic_read(&intf->dev.power.usage_count), 1819 - status); 1815 + pm_runtime_put(&intf->dev); 1816 + dev_vdbg(&intf->dev, "%s: cnt %d\n", 1817 + __func__, atomic_read(&intf->dev.power.usage_count)); 1820 1818 } 1821 1819 EXPORT_SYMBOL_GPL(usb_autopm_put_interface_async); 1822 1820