tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

HID: alps: fix NULL pointer dereference in alps_raw_event()

Commit ecfa6f34492c ("HID: Add HID_CLAIMED_INPUT guards in raw_event
callbacks missing them") attempted to fix up the HID drivers that had
missed the previous fix that was done in 2ff5baa9b527 ("HID: appleir:
Fix potential NULL dereference at raw event handle"), but the alps
driver was missed.

Fix this up by properly checking in the hid-alps driver that it had been
claimed correctly before attempting to process the raw event.

Fixes: 73196ebe134d ("HID: alps: add support for Alps T4 Touchpad device")
Cc: stable <stable@kernel.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <bentiss@kernel.org>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: linux-input@vger.kernel.org
Assisted-by: gregkh_clanker_t1000
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

authored by

Greg Kroah-Hartman and committed by
Jiri Kosina 1badfc43 b6a57912

+3
+3
drivers/hid/hid-alps.c
··· 437 437 int ret = 0; 438 438 struct alps_dev *hdata = hid_get_drvdata(hdev); 439 439 440 + if (!(hdev->claimed & HID_CLAIMED_INPUT) || !hdata->input) 441 + return 0; 442 + 440 443 switch (hdev->product) { 441 444 case HID_PRODUCT_ID_T4_BTNLESS: 442 445 ret = t4_raw_event(hdata, data, size);