tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

serial: sc16is7xx: remove useless enable of enhanced features

Commit 43c51bb573aa ("sc16is7xx: make sure device is in suspend once
probed") permanently enabled access to the enhanced features in
sc16is7xx_probe(), and it is never disabled after that.

Therefore, remove re-enable of enhanced features in
sc16is7xx_set_baud(). This eliminates a potential useless read + write
cycle each time the baud rate is reconfigured.

Fixes: 43c51bb573aa ("sc16is7xx: make sure device is in suspend once probed")
Cc: stable <stable@kernel.org>
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://patch.msgid.link/20251006142002.177475-1-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Hugo Villeneuve and committed by
Greg Kroah-Hartman 1c05bf6c e7cbce76

-7
-7
drivers/tty/serial/sc16is7xx.c
··· 588 588 div /= prescaler; 589 589 } 590 590 591 - /* Enable enhanced features */ 592 - sc16is7xx_efr_lock(port); 593 - sc16is7xx_port_update(port, SC16IS7XX_EFR_REG, 594 - SC16IS7XX_EFR_ENABLE_BIT, 595 - SC16IS7XX_EFR_ENABLE_BIT); 596 - sc16is7xx_efr_unlock(port); 597 - 598 591 /* If bit MCR_CLKSEL is set, the divide by 4 prescaler is activated. */ 599 592 sc16is7xx_port_update(port, SC16IS7XX_MCR_REG, 600 593 SC16IS7XX_MCR_CLKSEL_BIT,