tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

clk: qcom: common: Fix NULL vs IS_ERR() check in qcom_cc_icc_register()

The devm_clk_hw_get_clk() function doesn't return NULL, it returns error
pointers. Update the checking to match.

Fixes: 8737ec830ee3 ("clk: qcom: common: Add interconnect clocks support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/aLaPwL2gFS85WsfD@stanley.mountain
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Dan Carpenter and committed by
Bjorn Andersson 1e50f5c9 0e56e336

+2 -2
+2 -2
drivers/clk/qcom/common.c
··· 277 277 icd[i].slave_id = desc->icc_hws[i].slave_id; 278 278 hws = &desc->clks[desc->icc_hws[i].clk_id]->hw; 279 279 icd[i].clk = devm_clk_hw_get_clk(dev, hws, "icc"); 280 - if (!icd[i].clk) 281 - return dev_err_probe(dev, -ENOENT, 280 + if (IS_ERR(icd[i].clk)) 281 + return dev_err_probe(dev, PTR_ERR(icd[i].clk), 282 282 "(%d) clock entry is null\n", i); 283 283 icd[i].name = clk_hw_get_name(hws); 284 284 }