Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/sysfs-schemes: protect memcg_path kfree() with damon_sysfs_lock

Patch series "mm/damon/sysfs-schemes: fix use-after-free for [memcg_]path".

Reads of 'memcg_path' and 'path' files in DAMON sysfs interface could race
with their writes, results in use-after-free. Fix those.


This patch (of 2):

damon_sysfs_scheme_filter->mmecg_path can be read and written by users,
via DAMON sysfs memcg_path file. It can also be indirectly read, for the
parameters {on,off}line committing to DAMON. The reads for parameters
committing are protected by damon_sysfs_lock to avoid the sysfs files
being destroyed while any of the parameters are being read. But the
user-driven direct reads and writes are not protected by any lock, while
the write is deallocating the memcg_path-pointing buffer. As a result,
the readers could read the already freed buffer (user-after-free). Note
that the user-reads don't race when the same open file is used by the
writer, due to kernfs's open file locking. Nonetheless, doing the reads
and writes with separate open files would be common. Fix it by protecting
both the user-direct reads and writes with damon_sysfs_lock.

Link: https://lore.kernel.org/20260423150253.111520-1-sj@kernel.org
Link: https://lore.kernel.org/20260423150253.111520-2-sj@kernel.org
Fixes: 4f489fe6afb3 ("mm/damon/sysfs-schemes: free old damon_sysfs_scheme_filter->memcg_path on write")
Co-developed-by: Junxi Qian <qjx1298677004@gmail.com>
Signed-off-by: Junxi Qian <qjx1298677004@gmail.com>
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org> # 6.16.x
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

SeongJae Park and committed by
Andrew Morton
1e68eb96 2aeb64a2

+11 -1
+11 -1
mm/damon/sysfs-schemes.c
··· 533 533 { 534 534 struct damon_sysfs_scheme_filter *filter = container_of(kobj, 535 535 struct damon_sysfs_scheme_filter, kobj); 536 + int len; 536 537 537 - return sysfs_emit(buf, "%s\n", 538 + if (!mutex_trylock(&damon_sysfs_lock)) 539 + return -EBUSY; 540 + len = sysfs_emit(buf, "%s\n", 538 541 filter->memcg_path ? filter->memcg_path : ""); 542 + mutex_unlock(&damon_sysfs_lock); 543 + return len; 539 544 } 540 545 541 546 static ssize_t memcg_path_store(struct kobject *kobj, ··· 555 550 return -ENOMEM; 556 551 557 552 strscpy(path, buf, count + 1); 553 + if (!mutex_trylock(&damon_sysfs_lock)) { 554 + kfree(path); 555 + return -EBUSY; 556 + } 558 557 kfree(filter->memcg_path); 559 558 filter->memcg_path = path; 559 + mutex_unlock(&damon_sysfs_lock); 560 560 return count; 561 561 } 562 562