Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/amdgpu/userq: unmap_helper dont return the queue state
We check for return value of amdgpu_userq_unmap_helper and
compare it against the queue->state which is logically
wrong and we should just check for failure and do the needfull.
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
authored by
Sunil Khatri
and committed by
Alex Deucher
1e8b7062
810df8de
+1
-1
+1
-1
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
+1
-1
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
···
645
645
amdgpu_userq_detect_and_reset_queues(uq_mgr);
646
646
r = amdgpu_userq_unmap_helper(queue);
647
647
/*TODO: It requires a reset for userq hw unmap error*/
648
-
if (unlikely(r != AMDGPU_USERQ_STATE_UNMAPPED)) {
648
+
if (r) {
649
649
drm_warn(adev_to_drm(uq_mgr->adev), "trying to destroy a HW mapping userq\n");
650
650
queue->state = AMDGPU_USERQ_STATE_HUNG;
651
651
}