tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

nvmet: Introduce nvmet_get_cmd_effects_admin()

In order to have a logically better organized implementation of the
effects log page, split out reporting the supported admin commands from
nvmet_get_cmd_effects_nvm() into the new function
nvmet_get_cmd_effects_admin().

Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>

authored by

Damien Le Moal and committed by
Keith Busch 1ee45310 15e9d264

+6 -1
+6 -1
drivers/nvme/target/admin-cmd.c
··· 230 230 nvmet_req_complete(req, status); 231 231 } 232 232 233 - static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log) 233 + static void nvmet_get_cmd_effects_admin(struct nvme_effects_log *log) 234 234 { 235 235 log->acs[nvme_admin_get_log_page] = 236 236 log->acs[nvme_admin_identify] = ··· 240 240 log->acs[nvme_admin_async_event] = 241 241 log->acs[nvme_admin_keep_alive] = 242 242 cpu_to_le32(NVME_CMD_EFFECTS_CSUPP); 243 + } 243 244 245 + static void nvmet_get_cmd_effects_nvm(struct nvme_effects_log *log) 246 + { 244 247 log->iocs[nvme_cmd_read] = 245 248 log->iocs[nvme_cmd_flush] = 246 249 log->iocs[nvme_cmd_dsm] = ··· 279 276 280 277 switch (req->cmd->get_log_page.csi) { 281 278 case NVME_CSI_NVM: 279 + nvmet_get_cmd_effects_admin(log); 282 280 nvmet_get_cmd_effects_nvm(log); 283 281 break; 284 282 case NVME_CSI_ZNS: ··· 287 283 status = NVME_SC_INVALID_IO_CMD_SET; 288 284 goto free; 289 285 } 286 + nvmet_get_cmd_effects_admin(log); 290 287 nvmet_get_cmd_effects_nvm(log); 291 288 nvmet_get_cmd_effects_zns(log); 292 289 break;