Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/huge_memory: remove unnecessary sanity checks

These checks have been in place since 2014, I think we can safely assume
that we are in a place where we don't need these as runtime checks.

In addition there are 4 other invocations of folio_remove_rmap_pmd(), none
of which make this assertion.

If we need to add this assertion, it should be in folio_remove_rmap_pmd(),
and as a VM_WARN_ON_ONCE(), however these seem superfluous so just remove
them.

Link: https://lkml.kernel.org/r/0c4c5ab247c90f80cf44718e8124b217d6a22544.1774029655.git.ljs@kernel.org
Signed-off-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: Barry Song <baohua@kernel.org>
Cc: David Hildenbrand <david@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>
Cc: Lance Yang <lance.yang@linux.dev>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Nico Pache <npache@redhat.com>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Zi Yan <ziy@nvidia.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Lorenzo Stoakes (Oracle) and committed by
Andrew Morton
1fc034c1 d490940f

-2
-2
mm/huge_memory.c
··· 2448 2448 2449 2449 flush_needed = true; 2450 2450 folio_remove_rmap_pmd(folio, &folio->page, vma); 2451 - WARN_ON_ONCE(folio_mapcount(folio) < 0); 2452 2451 } else if (pmd_is_valid_softleaf(orig_pmd)) { 2453 2452 const softleaf_t entry = softleaf_from_pmd(orig_pmd); 2454 2453 ··· 2478 2479 2479 2480 if (folio_is_device_private(folio)) { 2480 2481 folio_remove_rmap_pmd(folio, &folio->page, vma); 2481 - WARN_ON_ONCE(folio_mapcount(folio) < 0); 2482 2482 folio_put(folio); 2483 2483 } 2484 2484