tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

octeontx2-af: Fix error code in rvu_mbox_init()

The error code was intended to be -EINVAL here, but it was accidentally
changed to returning success. Set the error code.

Fixes: e53ee4acb220 ("octeontx2-af: CN20k basic mbox operations and structures")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Dan Carpenter and committed by
David S. Miller 20a0c20f beead7ee

+2 -1
+2 -1
drivers/net/ethernet/marvell/octeontx2/af/rvu.c
··· 2458 2458 void (mbox_handler)(struct work_struct *), 2459 2459 void (mbox_up_handler)(struct work_struct *)) 2460 2460 { 2461 - int err = -EINVAL, i, dir, dir_up; 2462 2461 void __iomem **mbox_regions; 2463 2462 struct ng_rvu *ng_rvu_mbox; 2463 + int err, i, dir, dir_up; 2464 2464 void __iomem *reg_base; 2465 2465 struct rvu_work *mwork; 2466 2466 unsigned long *pf_bmap; ··· 2526 2526 goto free_regions; 2527 2527 break; 2528 2528 default: 2529 + err = -EINVAL; 2529 2530 goto free_regions; 2530 2531 } 2531 2532