tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

spi: cs42l43: Don't support sidecar properties on device tree systems

On some systems the cs42l43 has amplifiers attached to its
SPI controller that are not properly defined in ACPI. However,
this exists to provide compatibility with existing Windows ACPI.

On device tree systems this functionality should never be used,
there is no reason not to specify the amplifiers properly through
device tree. Make this more clear by only allowing the "sidecar"
functionality to be used on non-DT systems.

Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20260223100717.4011114-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Charles Keepax and committed by
Mark Brown 20a88c15 ffef4123

+2 -2
+2 -2
drivers/spi/spi-cs42l43.c
··· 367 367 ret = devm_add_action_or_reset(priv->dev, cs42l43_release_of_node, fwnode); 368 368 if (ret) 369 369 return ret; 370 + } else { 371 + fwnode_property_read_u32(xu_fwnode, "01fa-sidecar-instances", &nsidecars); 370 372 } 371 - 372 - fwnode_property_read_u32(xu_fwnode, "01fa-sidecar-instances", &nsidecars); 373 373 374 374 /* 375 375 * Depending on the value of nsidecars we either create a software node