tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Input: leds - annotate struct input_leds with __counted_by

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct input_leds.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922175031.work.467-kees@kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Kees Cook and committed by
Dmitry Torokhov 21d7ec79 8927e688

+1 -1
+1 -1
drivers/input/input-leds.c
··· 44 44 struct input_leds { 45 45 struct input_handle handle; 46 46 unsigned int num_leds; 47 - struct input_led leds[]; 47 + struct input_led leds[] __counted_by(num_leds); 48 48 }; 49 49 50 50 static enum led_brightness input_leds_brightness_get(struct led_classdev *cdev)