tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

fs: PM: Fix reverse check in filesystems_freeze_callback()

The freeze_all_ptr check in filesystems_freeze_callback() introduced by
commit a3f8f8662771 ("power: always freeze efivarfs") is reverse which
quite confusingly causes all file systems to be frozen when
filesystem_freeze_enabled is false.

On my systems it causes the WARN_ON_ONCE() in __set_task_frozen() to
trigger, most likely due to an attempt to freeze a file system that is
not ready for that.

Add a logical negation to the check in question to reverse it as
appropriate.

Fixes: a3f8f8662771 ("power: always freeze efivarfs")
Cc: 6.18+ <stable@vger.kernel.org> # 6.18+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/12788397.O9o76ZdvQC@rafael.j.wysocki
Signed-off-by: Christian Brauner <brauner@kernel.org>

authored by

Rafael J. Wysocki and committed by
Christian Brauner 222047f6 3f9f0252

+1 -1
+1 -1
fs/super.c
··· 1189 1189 if (!sb->s_op->freeze_fs && !sb->s_op->freeze_super) 1190 1190 return; 1191 1191 1192 - if (freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE)) 1192 + if (!freeze_all_ptr && !(sb->s_type->fs_flags & FS_POWER_FREEZE)) 1193 1193 return; 1194 1194 1195 1195 if (!get_active_super(sb))