tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

LTTPRs operating modes are defined by the DisplayPort standard and the
generic framework now provides a helper to switch between them, which
is handling the explicit disabling of non-transparent mode and its
disable->enable sequence mentioned in the DP Standard v2.0 section
3.6.6.1.

So use the new drm generic helper instead as it makes the code a bit
cleaner.

Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Danilo Krummrich <dakr@kernel.org> # via IRC
Link: https://patchwork.freedesktop.org/patch/msgid/20250203-drm-dp-msm-add-lttpr-transparent-mode-set-v5-2-c865d0e56d6e@linaro.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

authored by

Abel Vesa and committed by
Dmitry Baryshkov 226a0baf 5e771547

+2 -15
+2 -15
drivers/gpu/drm/nouveau/nouveau_dp.c
··· 79 79 !drm_dp_read_lttpr_common_caps(aux, dpcd, outp->dp.lttpr.caps)) { 80 80 int nr = drm_dp_lttpr_count(outp->dp.lttpr.caps); 81 81 82 - if (nr) { 83 - drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, 84 - DP_PHY_REPEATER_MODE_TRANSPARENT); 85 - 86 - if (nr > 0) { 87 - ret = drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, 88 - DP_PHY_REPEATER_MODE_NON_TRANSPARENT); 89 - if (ret != 1) { 90 - drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, 91 - DP_PHY_REPEATER_MODE_TRANSPARENT); 92 - } else { 93 - outp->dp.lttpr.nr = nr; 94 - } 95 - } 96 - } 82 + if (!drm_dp_lttpr_init(aux, nr)) 83 + outp->dp.lttpr.nr = nr; 97 84 } 98 85 99 86 ret = drm_dp_read_dpcd_caps(aux, dpcd);