Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

aio: mark AIO pseudo-fs noexec

This ensures that do_mmap() won't implicitly make AIO memory mappings
executable if the READ_IMPLIES_EXEC personality flag is set. Such
behavior is problematic because the security_mmap_file LSM hook doesn't
catch this case, potentially permitting an attacker to bypass a W^X
policy enforced by SELinux.

I have tested the patch on my machine.

To test the behavior, compile and run this:

#define _GNU_SOURCE
#include <unistd.h>
#include <sys/personality.h>
#include <linux/aio_abi.h>
#include <err.h>
#include <stdlib.h>
#include <stdio.h>
#include <sys/syscall.h>

int main(void) {
personality(READ_IMPLIES_EXEC);
aio_context_t ctx = 0;
if (syscall(__NR_io_setup, 1, &ctx))
err(1, "io_setup");

char cmd[1000];
sprintf(cmd, "cat /proc/%d/maps | grep -F '/[aio]'",
(int)getpid());
system(cmd);
return 0;
}

In the output, "rw-s" is good, "rwxs" is bad.

Signed-off-by: Jann Horn <jann@thejh.net>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Jann Horn and committed by
Linus Torvalds
22f6b4d3 024c7e37

+6 -1
+6 -1
fs/aio.c
··· 239 239 static const struct dentry_operations ops = { 240 240 .d_dname = simple_dname, 241 241 }; 242 - return mount_pseudo(fs_type, "aio:", NULL, &ops, AIO_RING_MAGIC); 242 + struct dentry *root = mount_pseudo(fs_type, "aio:", NULL, &ops, 243 + AIO_RING_MAGIC); 244 + 245 + if (!IS_ERR(root)) 246 + root->d_sb->s_iflags |= SB_I_NOEXEC; 247 + return root; 243 248 } 244 249 245 250 /* aio_setup