Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/i915/dsi: log send packet sequence errors
We might be getting send packet sequence errors and never know. Log them
as errors. Also upgrade the not supported read commands to errors.
v2: Also error log -EOPNOTSUPP (Ville)
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20251029084603.2254982-1-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
+13
-9
+13
-9
drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+13
-9
drivers/gpu/drm/i915/display/intel_dsi_vbt.c
···
106
106
u8 type, flags, seq_port;
107
107
u16 len;
108
108
enum port port;
109
+
ssize_t ret;
109
110
110
111
drm_dbg_kms(display->drm, "\n");
111
112
···
139
138
140
139
switch (type) {
141
140
case MIPI_DSI_GENERIC_SHORT_WRITE_0_PARAM:
142
-
mipi_dsi_generic_write(dsi_device, NULL, 0);
141
+
ret = mipi_dsi_generic_write(dsi_device, NULL, 0);
143
142
break;
144
143
case MIPI_DSI_GENERIC_SHORT_WRITE_1_PARAM:
145
-
mipi_dsi_generic_write(dsi_device, data, 1);
144
+
ret = mipi_dsi_generic_write(dsi_device, data, 1);
146
145
break;
147
146
case MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM:
148
-
mipi_dsi_generic_write(dsi_device, data, 2);
147
+
ret = mipi_dsi_generic_write(dsi_device, data, 2);
149
148
break;
150
149
case MIPI_DSI_GENERIC_READ_REQUEST_0_PARAM:
151
150
case MIPI_DSI_GENERIC_READ_REQUEST_1_PARAM:
152
151
case MIPI_DSI_GENERIC_READ_REQUEST_2_PARAM:
153
-
drm_dbg_kms(display->drm, "Generic Read not yet implemented or used\n");
152
+
ret = -EOPNOTSUPP;
154
153
break;
155
154
case MIPI_DSI_GENERIC_LONG_WRITE:
156
-
mipi_dsi_generic_write(dsi_device, data, len);
155
+
ret = mipi_dsi_generic_write(dsi_device, data, len);
157
156
break;
158
157
case MIPI_DSI_DCS_SHORT_WRITE:
159
-
mipi_dsi_dcs_write_buffer(dsi_device, data, 1);
158
+
ret = mipi_dsi_dcs_write_buffer(dsi_device, data, 1);
160
159
break;
161
160
case MIPI_DSI_DCS_SHORT_WRITE_PARAM:
162
-
mipi_dsi_dcs_write_buffer(dsi_device, data, 2);
161
+
ret = mipi_dsi_dcs_write_buffer(dsi_device, data, 2);
163
162
break;
164
163
case MIPI_DSI_DCS_READ:
165
-
drm_dbg_kms(display->drm, "DCS Read not yet implemented or used\n");
164
+
ret = -EOPNOTSUPP;
166
165
break;
167
166
case MIPI_DSI_DCS_LONG_WRITE:
168
-
mipi_dsi_dcs_write_buffer(dsi_device, data, len);
167
+
ret = mipi_dsi_dcs_write_buffer(dsi_device, data, len);
169
168
break;
170
169
}
170
+
171
+
if (ret < 0)
172
+
drm_err(display->drm, "DSI send packet failed with %pe\n", ERR_PTR(ret));
171
173
172
174
if (DISPLAY_VER(display) < 11)
173
175
vlv_dsi_wait_for_fifo_empty(intel_dsi, port);