tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

ASoC: aw88395: Fix kernel panic caused by invalid GPIO error pointer

In aw88395_i2c_probe(), if `devm_gpiod_get_optional()` fails, it returns
an ERR_PTR() error pointer. The current code only prints a message and
continues execution, leaving `aw88395->reset_gpio` as an invalid pointer.

Later, in `aw88395_hw_reset()`, this invalid pointer is passed to
`gpiod_set_value_cansleep()`, which dereferences it and causes a kernel
panic.

For optional GPIOs, `devm_gpiod_get_optional()` returns NULL if the GPIO
is not defined in the DT, which is safe. If it returns an ERR_PTR, it
means a real error occurred (e.g., -EPROBE_DEFER) and the probe must be
aborted.

Also, since the GPIO is optional, remove the dev_err() log in
aw88395_hw_reset() when the GPIO is missing to match the optional
semantics. This also fixes a potential NULL pointer dereference as
aw_pa is not initialized when aw88395_hw_reset() is called.

Signed-off-by: wangdicheng <wangdicheng@kylinos.cn>
Link: https://patch.msgid.link/20260428023408.46420-1-wangdich9700@163.com
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

wangdicheng and committed by
Mark Brown 241ee17e 8ed33111

+4 -5
+4 -5
sound/soc/codecs/aw88395/aw88395.c
··· 456 456 usleep_range(AW88395_1000_US, AW88395_1000_US + 10); 457 457 gpiod_set_value_cansleep(aw88395->reset_gpio, 1); 458 458 usleep_range(AW88395_1000_US, AW88395_1000_US + 10); 459 - } else { 460 - dev_err(aw88395->aw_pa->dev, "%s failed", __func__); 461 459 } 462 460 } 463 461 ··· 520 522 i2c_set_clientdata(i2c, aw88395); 521 523 522 524 aw88395->reset_gpio = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW); 523 - if (IS_ERR(aw88395->reset_gpio)) 524 - dev_info(&i2c->dev, "reset gpio not defined\n"); 525 - 525 + if (IS_ERR(aw88395->reset_gpio)) { 526 + return dev_err_probe(&i2c->dev, PTR_ERR(aw88395->reset_gpio), 527 + "failed to get reset gpio\n"); 528 + } 526 529 /* hardware reset */ 527 530 aw88395_hw_reset(aw88395); 528 531