tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mei: txe: fix initialization order

The mei_register() should move before the mei_start() for hook
on class device to work.
Same change was implemented in mei-me, missed from mei-txe.

Fixes: 7704e6be4ed2 ("mei: hook mei_device on class device")
Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Link: https://patch.msgid.link/20251019073659.2646791-1-alexander.usyskin@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Alexander Usyskin and committed by
Greg Kroah-Hartman 2463ae28 87b318ba

+7 -7
+7 -7
drivers/misc/mei/pci-txe.c
··· 109 109 goto end; 110 110 } 111 111 112 + err = mei_register(dev, &pdev->dev); 113 + if (err) 114 + goto release_irq; 115 + 112 116 if (mei_start(dev)) { 113 117 dev_err(&pdev->dev, "init hw failure.\n"); 114 118 err = -ENODEV; 115 - goto release_irq; 119 + goto deregister; 116 120 } 117 121 118 122 pm_runtime_set_autosuspend_delay(&pdev->dev, MEI_TXI_RPM_TIMEOUT); 119 123 pm_runtime_use_autosuspend(&pdev->dev); 120 - 121 - err = mei_register(dev, &pdev->dev); 122 - if (err) 123 - goto stop; 124 124 125 125 pci_set_drvdata(pdev, dev); 126 126 ··· 144 144 145 145 return 0; 146 146 147 - stop: 148 - mei_stop(dev); 147 + deregister: 148 + mei_deregister(dev); 149 149 release_irq: 150 150 mei_cancel_work(dev); 151 151 mei_disable_interrupts(dev);