Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

fbdev: macfb: Replace deprecated strcpy with strscpy

strcpy() has been deprecated [1] because it performs no bounds checking
on the destination buffer, which can lead to buffer overflows. Replace
it with the safer strscpy(). No functional changes.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Thorsten Blum and committed by
Helge Deller
24d11b25 d95beb0a

+19 -19
+19 -19
drivers/video/fbdev/macfb.c
··· 668 668 669 669 switch(ndev->dr_hw) { 670 670 case NUBUS_DRHW_APPLE_MDC: 671 - strcpy(macfb_fix.id, "Mac Disp. Card"); 671 + strscpy(macfb_fix.id, "Mac Disp. Card"); 672 672 macfb_setpalette = mdc_setpalette; 673 673 break; 674 674 case NUBUS_DRHW_APPLE_TFB: 675 - strcpy(macfb_fix.id, "Toby"); 675 + strscpy(macfb_fix.id, "Toby"); 676 676 macfb_setpalette = toby_setpalette; 677 677 break; 678 678 case NUBUS_DRHW_APPLE_JET: 679 - strcpy(macfb_fix.id, "Jet"); 679 + strscpy(macfb_fix.id, "Jet"); 680 680 macfb_setpalette = jet_setpalette; 681 681 break; 682 682 default: 683 - strcpy(macfb_fix.id, "Generic NuBus"); 683 + strscpy(macfb_fix.id, "Generic NuBus"); 684 684 break; 685 685 } 686 686 } ··· 707 707 case MAC_MODEL_Q700: 708 708 case MAC_MODEL_Q900: 709 709 case MAC_MODEL_Q950: 710 - strcpy(macfb_fix.id, "DAFB"); 710 + strscpy(macfb_fix.id, "DAFB"); 711 711 macfb_setpalette = dafb_setpalette; 712 712 dafb_cmap_regs = ioremap(DAFB_BASE, 0x1000); 713 713 break; ··· 716 716 * LC II uses the V8 framebuffer 717 717 */ 718 718 case MAC_MODEL_LCII: 719 - strcpy(macfb_fix.id, "V8"); 719 + strscpy(macfb_fix.id, "V8"); 720 720 macfb_setpalette = v8_brazil_setpalette; 721 721 v8_brazil_cmap_regs = ioremap(DAC_BASE, 0x1000); 722 722 break; ··· 729 729 case MAC_MODEL_IIVI: 730 730 case MAC_MODEL_IIVX: 731 731 case MAC_MODEL_P600: 732 - strcpy(macfb_fix.id, "Brazil"); 732 + strscpy(macfb_fix.id, "Brazil"); 733 733 macfb_setpalette = v8_brazil_setpalette; 734 734 v8_brazil_cmap_regs = ioremap(DAC_BASE, 0x1000); 735 735 break; ··· 745 745 case MAC_MODEL_P520: 746 746 case MAC_MODEL_P550: 747 747 case MAC_MODEL_P460: 748 - strcpy(macfb_fix.id, "Sonora"); 748 + strscpy(macfb_fix.id, "Sonora"); 749 749 macfb_setpalette = v8_brazil_setpalette; 750 750 v8_brazil_cmap_regs = ioremap(DAC_BASE, 0x1000); 751 751 break; ··· 757 757 */ 758 758 case MAC_MODEL_IICI: 759 759 case MAC_MODEL_IISI: 760 - strcpy(macfb_fix.id, "RBV"); 760 + strscpy(macfb_fix.id, "RBV"); 761 761 macfb_setpalette = rbv_setpalette; 762 762 rbv_cmap_regs = ioremap(DAC_BASE, 0x1000); 763 763 break; ··· 767 767 */ 768 768 case MAC_MODEL_Q840: 769 769 case MAC_MODEL_C660: 770 - strcpy(macfb_fix.id, "Civic"); 770 + strscpy(macfb_fix.id, "Civic"); 771 771 macfb_setpalette = civic_setpalette; 772 772 civic_cmap_regs = ioremap(CIVIC_BASE, 0x1000); 773 773 break; ··· 778 778 * We think this may be like the LC II 779 779 */ 780 780 case MAC_MODEL_LC: 781 - strcpy(macfb_fix.id, "LC"); 781 + strscpy(macfb_fix.id, "LC"); 782 782 if (vidtest) { 783 783 macfb_setpalette = v8_brazil_setpalette; 784 784 v8_brazil_cmap_regs = ··· 790 790 * We think this may be like the LC II 791 791 */ 792 792 case MAC_MODEL_CCL: 793 - strcpy(macfb_fix.id, "Color Classic"); 793 + strscpy(macfb_fix.id, "Color Classic"); 794 794 if (vidtest) { 795 795 macfb_setpalette = v8_brazil_setpalette; 796 796 v8_brazil_cmap_regs = ··· 802 802 * And we *do* mean "weirdos" 803 803 */ 804 804 case MAC_MODEL_TV: 805 - strcpy(macfb_fix.id, "Mac TV"); 805 + strscpy(macfb_fix.id, "Mac TV"); 806 806 break; 807 807 808 808 /* ··· 810 810 */ 811 811 case MAC_MODEL_SE30: 812 812 case MAC_MODEL_CLII: 813 - strcpy(macfb_fix.id, "Monochrome"); 813 + strscpy(macfb_fix.id, "Monochrome"); 814 814 break; 815 815 816 816 /* ··· 828 828 case MAC_MODEL_PB140: 829 829 case MAC_MODEL_PB145: 830 830 case MAC_MODEL_PB170: 831 - strcpy(macfb_fix.id, "DDC"); 831 + strscpy(macfb_fix.id, "DDC"); 832 832 break; 833 833 834 834 /* ··· 840 840 case MAC_MODEL_PB180: 841 841 case MAC_MODEL_PB210: 842 842 case MAC_MODEL_PB230: 843 - strcpy(macfb_fix.id, "GSC"); 843 + strscpy(macfb_fix.id, "GSC"); 844 844 break; 845 845 846 846 /* ··· 848 848 */ 849 849 case MAC_MODEL_PB165C: 850 850 case MAC_MODEL_PB180C: 851 - strcpy(macfb_fix.id, "TIM"); 851 + strscpy(macfb_fix.id, "TIM"); 852 852 break; 853 853 854 854 /* ··· 860 860 case MAC_MODEL_PB270C: 861 861 case MAC_MODEL_PB280: 862 862 case MAC_MODEL_PB280C: 863 - strcpy(macfb_fix.id, "CSC"); 863 + strscpy(macfb_fix.id, "CSC"); 864 864 macfb_setpalette = csc_setpalette; 865 865 csc_cmap_regs = ioremap(CSC_BASE, 0x1000); 866 866 break; 867 867 868 868 default: 869 - strcpy(macfb_fix.id, "Unknown"); 869 + strscpy(macfb_fix.id, "Unknown"); 870 870 break; 871 871 } 872 872