tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

page_pool: fix &page_pool_params kdoc issues

After the tagged commit, @netdev got documented twice and the kdoc
script didn't notice that. Remove the second description added later
and move the initial one according to the field position.

After merging commit 5f8e4007c10d ("kernel-doc: fix
struct_group_tagged() parsing"), kdoc requires to describe struct
groups as well. &page_pool_params has 2 struct groups which
generated new warnings, describe them to resolve this.

Fixes: 403f11ac9ab7 ("page_pool: don't use driver-set flags field directly")
Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Link: https://lore.kernel.org/r/20240524112859.2757403-1-aleksander.lobakin@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Alexander Lobakin and committed by
Jakub Kicinski 266aa3b4 4fb67904

+3 -2
+3 -2
include/net/page_pool/types.h
··· 45 45 46 46 /** 47 47 * struct page_pool_params - page pool parameters 48 + * @fast: params accessed frequently on hotpath 48 49 * @order: 2^order pages on allocation 49 50 * @pool_size: size of the ptr_ring 50 51 * @nid: NUMA node id to allocate from pages from 51 52 * @dev: device, for DMA pre-mapping purposes 52 - * @netdev: netdev this pool will serve (leave as NULL if none or multiple) 53 53 * @napi: NAPI which is the sole consumer of pages, otherwise NULL 54 54 * @dma_dir: DMA mapping direction 55 55 * @max_len: max DMA sync memory size for PP_FLAG_DMA_SYNC_DEV 56 56 * @offset: DMA sync address offset for PP_FLAG_DMA_SYNC_DEV 57 - * @netdev: corresponding &net_device for Netlink introspection 57 + * @slow: params with slowpath access only (initialization and Netlink) 58 + * @netdev: netdev this pool will serve (leave as NULL if none or multiple) 58 59 * @flags: PP_FLAG_DMA_MAP, PP_FLAG_DMA_SYNC_DEV, PP_FLAG_SYSTEM_POOL 59 60 */ 60 61 struct page_pool_params {