tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: cdns-dphy: Remove leftover code

The code in cdns-dphy has probably been part of a DSI driver in the
past. Remove DSI defines and variables which are not used or do not
actually do anything. Also rename cdns_dsi_get_dphy_pll_cfg() to
cdns_dphy_get_pll_cfg(), i.e. drop the "dsi", as it's not relevant here.

Reviewed-by: Aradhya Bhatia <aradhya.bhatia@linux.dev>
Tested-by: Parth Pancholi <parth.pancholi@toradex.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Tested-by: Jayesh Choudhary <j-choudhary@ti.com>
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://lore.kernel.org/r/20250723-cdns-dphy-hs-clk-rate-fix-v1-2-d4539d44cbe7@ideasonboard.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Tomi Valkeinen and committed by
Vinod Koul 2674eb71 689a54ac

+4 -15
+4 -15
drivers/phy/cadence/cdns-dphy.c
··· 55 55 #define DPHY_PSM_CFG_FROM_REG BIT(0) 56 56 #define DPHY_PSM_CLK_DIV(x) ((x) << 1) 57 57 58 - #define DSI_HBP_FRAME_OVERHEAD 12 59 - #define DSI_HSA_FRAME_OVERHEAD 14 60 - #define DSI_HFP_FRAME_OVERHEAD 6 61 - #define DSI_HSS_VSS_VSE_FRAME_OVERHEAD 4 62 - #define DSI_BLANKING_FRAME_OVERHEAD 6 63 - #define DSI_NULL_FRAME_OVERHEAD 6 64 - #define DSI_EOT_PKT_SIZE 4 65 - 66 58 #define DPHY_TX_J721E_WIZ_PLL_CTRL 0xF04 67 59 #define DPHY_TX_J721E_WIZ_STATUS 0xF08 68 60 #define DPHY_TX_J721E_WIZ_RST_CTRL 0xF0C ··· 109 117 870, 950, 1000, 1200, 1400, 1600, 1800, 2000, 2200, 2500 110 118 }; 111 119 112 - static int cdns_dsi_get_dphy_pll_cfg(struct cdns_dphy *dphy, 113 - struct cdns_dphy_cfg *cfg, 114 - struct phy_configure_opts_mipi_dphy *opts, 115 - unsigned int *dsi_hfp_ext) 120 + static int cdns_dphy_get_pll_cfg(struct cdns_dphy *dphy, 121 + struct cdns_dphy_cfg *cfg, 122 + struct phy_configure_opts_mipi_dphy *opts) 116 123 { 117 124 unsigned long pll_ref_hz = clk_get_rate(dphy->pll_ref_clk); 118 125 u64 dlane_bps; ··· 280 289 struct cdns_dphy_cfg *cfg) 281 290 { 282 291 struct cdns_dphy *dphy = phy_get_drvdata(phy); 283 - unsigned int dsi_hfp_ext = 0; 284 292 int ret; 285 293 286 294 ret = phy_mipi_dphy_config_validate(opts); 287 295 if (ret) 288 296 return ret; 289 297 290 - ret = cdns_dsi_get_dphy_pll_cfg(dphy, cfg, 291 - opts, &dsi_hfp_ext); 298 + ret = cdns_dphy_get_pll_cfg(dphy, cfg, opts); 292 299 if (ret) 293 300 return ret; 294 301