tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

selftests/resctrl: Make "bandwidth" consistent in comments & prints

Resctrl selftests refer to "bandwidth" currently in two other forms in
the code ("B/W" and "band width").

Use "bandwidth" consistently everywhere. While at it, fix also one
"over flow" -> "overflow" on a line that is touched by the change.

Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tested-by: Babu Moger <babu.moger@amd.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

authored by

Ilpo Järvinen and committed by
Shuah Khan 2704b2d1 da50de0a

+8 -8
+7 -7
tools/testing/selftests/resctrl/resctrl_val.c
··· 361 361 } 362 362 363 363 /* 364 - * get_mem_bw_imc - Memory band width as reported by iMC counters 364 + * get_mem_bw_imc - Memory bandwidth as reported by iMC counters 365 365 * @bw_report: Bandwidth report type (reads, writes) 366 366 * 367 - * Memory B/W utilized by a process on a socket can be calculated using 368 - * iMC counters. Perf events are used to read these counters. 367 + * Memory bandwidth utilized by a process on a socket can be calculated 368 + * using iMC counters. Perf events are used to read these counters. 369 369 * 370 370 * Return: = 0 on success. < 0 on failure. 371 371 */ ··· 379 379 380 380 /* 381 381 * Get results which are stored in struct type imc_counter_config 382 - * Take over flow into consideration before calculating total b/w 382 + * Take overflow into consideration before calculating total bandwidth. 383 383 */ 384 384 for (imc = 0; imc < imcs; imc++) { 385 385 struct imc_counter_config *r = ··· 389 389 390 390 if (read(r->fd, &r->return_value, 391 391 sizeof(struct membw_read_format)) == -1) { 392 - ksft_perror("Couldn't get read b/w through iMC"); 392 + ksft_perror("Couldn't get read bandwidth through iMC"); 393 393 return -1; 394 394 } 395 395 396 396 if (read(w->fd, &w->return_value, 397 397 sizeof(struct membw_read_format)) == -1) { 398 - ksft_perror("Couldn't get write bw through iMC"); 398 + ksft_perror("Couldn't get write bandwidth through iMC"); 399 399 return -1; 400 400 } 401 401 ··· 492 492 493 493 fp = fopen(mbm_bw_file, "r"); 494 494 if (!fp) 495 - ksft_perror("Failed to open total bw file"); 495 + ksft_perror("Failed to open total memory bandwidth file"); 496 496 497 497 return fp; 498 498 }
+1 -1
tools/testing/selftests/resctrl/resctrlfs.c
··· 850 850 if (strcmp(bw_report, "total") == 0) 851 851 return 0; 852 852 853 - fprintf(stderr, "Requested iMC B/W report type unavailable\n"); 853 + fprintf(stderr, "Requested iMC bandwidth report type unavailable\n"); 854 854 855 855 return -1; 856 856 }