Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

fs/ntfs3: prevent infinite loops caused by the next valid being the same

When processing valid within the range [valid : pos), if valid cannot
be retrieved correctly, for example, if the retrieved valid value is
always the same, this can trigger a potential infinite loop, similar
to the hung problem reported by syzbot [1].

Adding a check for the valid value within the loop body, and terminating
the loop and returning -EINVAL if the value is the same as the current
value, can prevent this.

[1]
INFO: task syz.4.21:6056 blocked for more than 143 seconds.
Call Trace:
rwbase_write_lock+0x14f/0x750 kernel/locking/rwbase_rt.c:244
inode_lock include/linux/fs.h:1027 [inline]
ntfs_file_write_iter+0xe6/0x870 fs/ntfs3/file.c:1284

Fixes: 4342306f0f0d ("fs/ntfs3: Add file operations and implementation")
Reported-by: syzbot+bcf9e1868c1a0c7e04f1@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=bcf9e1868c1a0c7e04f1
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>

authored by

Edward Adam Davis and committed by
Konstantin Komarov
27b75ca4 1dad2fff

+6 -2
+6 -2
fs/ntfs3/file.c
··· 1016 1016 goto out; 1017 1017 1018 1018 if (lcn == SPARSE_LCN) { 1019 - ni->i_valid = valid = 1020 - frame_vbo + ((u64)clen << sbi->cluster_bits); 1019 + valid = frame_vbo + ((u64)clen << sbi->cluster_bits); 1020 + if (ni->i_valid == valid) { 1021 + err = -EINVAL; 1022 + goto out; 1023 + } 1024 + ni->i_valid = valid; 1021 1025 continue; 1022 1026 } 1023 1027