tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

platform/x86: toshiba_acpi: Fix missing error code in toshiba_acpi_setup_keyboard()

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'error'.

Eliminate the follow smatch warning:

drivers/platform/x86/toshiba_acpi.c:2834 toshiba_acpi_setup_keyboard()
warn: missing error code 'error'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/1622628348-87035-1-git-send-email-jiapeng.chong@linux.alibaba.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

authored by

Jiapeng Chong and committed by
Hans de Goede 28e36712 f7b056b4

+1
+1
drivers/platform/x86/toshiba_acpi.c
··· 2831 2831 2832 2832 if (!dev->info_supported && !dev->system_event_supported) { 2833 2833 pr_warn("No hotkey query interface found\n"); 2834 + error = -EINVAL; 2834 2835 goto err_remove_filter; 2835 2836 } 2836 2837